add ispunct function to check if a word is a punctuation #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alerque
suggested changes
Oct 24, 2024
| @@ -503,6 +503,10 @@ for idx,value in ipairs({ 1, 5 }) do | |||
| assert(clusters[idx] == value) | |||
| end | |||
|
|
|||
| local str = '中文标点符号测试：文字内容，９８满意,hello world' | |||
| for p, ch in utf8.codes(str) do | |||
| print (ch, utf8.char(ch), utf8.ispunct(ch)) | |||
There was a problem hiding this comment.
Just printing an output isn't enough to test this, you need to actually have some test or assertion that proves the result is what it is expected to be for a given input.
|
I'm not very approve with this API, you should just use "%p" to match a Unicode punctuation. If you add this one, all Unicode categories should all have their own API. That makes this library messy. |
|
Thank you. I see.
…________________________________
发件人: Xavier Wang ***@***.***>
发送时间: 2024年10月25日 4:37
收件人: starwing/luautf8 ***@***.***>
抄送: chenghf ***@***.***>; Author ***@***.***>
主题: Re: [starwing/luautf8] add ispunct function to check if a word is a punctuation (PR #54)
I'm not very familiar with this API, you should just use "%p" to match a Unicode punctuation. If you add this one, all Unicode categories should all have their own API. That makes this library messy.
―
Reply to this email directly, view it on GitHub<#54 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAAO4N46OWVTKAWERPEMG3LZ5FLA7AVCNFSM6AAAAABQQNT4COVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZWGI4TINBQGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.