Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single image containing nginx and php #69

Closed
leojonathanoh opened this issue Nov 2, 2023 · 0 comments · Fixed by #70
Closed

Single image containing nginx and php #69

leojonathanoh opened this issue Nov 2, 2023 · 0 comments · Fixed by #70
Assignees
@leojonathanoh
Labels
enhancement New feature or request
Milestone
3.3.0

Comments

@leojonathanoh
Copy link
Member

leojonathanoh commented Nov 2, 2023 •
edited
Loading

Current

Separate nginx and php images

Expectation

Single image containing nginx and php.

Discussion

Currently the nginx and php are in separate images.

Benefits:

  • Separation of concerns principle
  • Independent scalability of nginx and php
  • Better security

Drawbacks:

  • More difficult to deploy. Requires two separate containers to serve one application. Application does not work until both containers have started
  • More difficult to upgrade, since two tags must be bumped
  • Environment variables for the PHP application are specified only on the PHP container only, which is confusing
  • nginx.conf config file requires hostname of php, which means that either: 1) nginx container may require an env variable like PHP_HOSTNAME which overrides a value in nginx.conf (which is not conventional and difficult to understand), or 2) user needs to use a custom nginx.conf. Instead, if they were in the same container, 127.0.0.1 may simply be used.
@leojonathanoh leojonathanoh added the enhancement New feature or request label Nov 2, 2023
@leojonathanoh leojonathanoh self-assigned this Nov 2, 2023
@leojonathanoh leojonathanoh added this to the 3.3.0 milestone Nov 2, 2023
leojonathanoh added a commit that referenced this issue Nov 7, 2023
@leojonathanoh
Change (docker): Combine nginx and php to a single image for both `AS…
d32d92f 
…P` and `bf2sclone` with env var support for configuration

In <= v3.2.0, `asp` had separate `nginx` and `php` images.

Now: `asp` image containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:

- Easier to deploy / upgrade. No need to separate `nginx` and `php` containers
- Environment variable configuration means no more need to mount config into `asp` and `bf2sclone` containers
- Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume

Notable changes:
- Add documentation for upgrading docker images to v3.3.x from prior versions
- Update `./docs/examples`
- Add tests for production builds for examples in `./docs/examples`

Closes #69
@leojonathanoh leojonathanoh mentioned this issue Nov 7, 2023
Merged
leojonathanoh added a commit that referenced this issue Nov 7, 2023
@leojonathanoh
Change (docker): Combine nginx and php to a single image for both `AS…
f893a5c 
…P` with env var support for configuration

In <= v3.2.0, `asp` had separate `nginx` and `php` images.

Now: `asp` image containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:

- Easier to deploy / upgrade. No need to separate `nginx` and `php` containers
- Environment variable configuration means no more need to mount config into `asp` and `bf2sclone` containers
- Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume

Notable changes:
- Add documentation for upgrading docker images to v3.3.x from prior versions
- Update `./docs/examples`
- Add tests for production builds for examples in `./docs/examples`

Closes #69
leojonathanoh added a commit that referenced this issue Nov 7, 2023
@leojonathanoh
Change (docker): Combine nginx and php to a single image for both `AS…
a0ed8ce 
…P` with env var support for configuration

In <= v3.2.0, `asp` had separate `nginx` and `php` images.

Now: `asp` image containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:

- Easier to deploy / upgrade. No need to separate `nginx` and `php` containers
- Environment variable configuration means no more need to mount config into `asp` container
- Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume

Notable changes:
- Add documentation for upgrading docker images to v3.3.x from prior versions
- Update `./docs/examples`
- Add tests for production builds for examples in `./docs/examples`

Closes #69
leojonathanoh added a commit that referenced this issue Nov 7, 2023
@leojonathanoh
Change (docker): Combine nginx and php to a single image for both `AS…
f7b193a 
…P` with env var support for configuration

In <= v3.2.0, `asp` had separate `nginx` and `php` images.

Now: `asp` image containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:

- Easier to deploy / upgrade. No need to separate `nginx` and `php` containers
- Environment variable configuration means no more need to mount config into `asp` container
- Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume

Notable changes:
- Add documentation for upgrading docker images to v3.3.x from prior versions
- Update `./docs/examples`
- Add tests for production builds for examples in `./docs/examples`

Closes #69
leojonathanoh added a commit that referenced this issue Nov 22, 2023
@leojonathanoh
Change (docker): Combine nginx and php to a single image for ASP wi…
87c33b5 
…th env var support for configuration

In <= v3.2.0, `asp` had separate `nginx` and `php` images.

Now: `asp` image containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:

- Easier to deploy / upgrade. No need to separate `nginx` and `php` containers
- Environment variable configuration means no more need to mount config into `asp` container
- Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume

Notable changes:
- Add documentation for upgrading docker images to v3.3.x from prior versions
- Update `./docs/examples`
- Add tests for production builds for examples in `./docs/examples`

Closes #69
leojonathanoh added a commit that referenced this issue Nov 22, 2023
@leojonathanoh
Change (docker): Combine nginx and php to a single image for ASP wi…
63d01bc 
…th env var support for configuration

In <= v3.2.0, `asp` had separate `nginx` and `php` images.

Now: `asp` image containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:

- Easier to deploy / upgrade. No need to separate `nginx` and `php` containers
- Environment variable configuration means no more need to mount config into `asp` container
- Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume

Notable changes:
- Add documentation for upgrading docker images to v3.3.x from prior versions
- Update `./docs/examples`
- Add tests for production builds for examples in `./docs/examples`

Closes #69
leojonathanoh added a commit that referenced this issue Nov 22, 2023
@leojonathanoh
Change (docker): Combine nginx and php to a single image for ASP wi…
afef1cf 
…th env var support for configuration

In <= v3.2.0, `asp` had separate `nginx` and `php` images.

Now: `asp` image containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:

- Easier to deploy / upgrade. No need to separate `nginx` and `php` containers
- Environment variable configuration means no more need to mount config into `asp` container
- Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume

Notable changes:
- Add documentation for upgrading docker images to v3.3.x from prior versions
- Update `./docs/examples`
- Add tests for production builds for examples in `./docs/examples`

Closes #69
leojonathanoh added a commit that referenced this issue Nov 22, 2023
@leojonathanoh
Change (docker): Combine nginx and php to a single image for ASP wi…
e565562 
…th env var support for configuration

In <= v3.2.0, `asp` had separate `nginx` and `php` images.

Now: `asp` image containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:

- Easier to deploy / upgrade. No need to separate `nginx` and `php` containers
- Environment variable configuration means no more need to mount config into `asp` container
- Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume

Notable changes:
- Add documentation for upgrading docker images to v3.3.x from prior versions
- Update `./docs/examples`
- Add tests for production builds for examples in `./docs/examples`

Closes #69
leojonathanoh added a commit that referenced this issue Nov 22, 2023
@leojonathanoh
Change (docker): Combine nginx and php to a single image for ASP wi…
0deb8c6 
…th env var support for configuration

In <= v3.2.0, `asp` had separate `nginx` and `php` images.

Now: `asp` image containing both `nginx` and `php`, with environment variable support, and entrypoint that sets the correct permissions.

Benefits:

- Easier to deploy / upgrade. No need to separate `nginx` and `php` containers
- Environment variable configuration means no more need to mount config into `asp` container
- Entrypoint script sets permissions on volumes. `init-container` should only need to set permissions for `db` volume

Notable changes:
- Add documentation for upgrading docker images to v3.3.x from prior versions
- Update `./docs/examples`
- Add tests for production builds for examples in `./docs/examples`

Closes #69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leojonathanoh leojonathanoh

Labels
enhancement New feature or request
Projects
None yet
Milestone
3.3.0
1 participant
@leojonathanoh