feat(fee): add linear combination for gas and blob_gas, modify relevant tests

[aner-starkware]

Modified the tests:
test_calculate_tx_gas_usage_basic, test_invoke_tx, test_declare_tx, test_deploy_account_tx, test_l1_handler, test_calculate_tx_gas_usage

---

This change is 

[codecov-commenter]

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (0a5416b) 70.43% compared to head (e9e2e0a) 70.57%.

Files	Patch %	Lines
crates/blockifier/src/fee/gas_usage.rs	81.08%	5 Missing and 2 partials ⚠️
crates/blockifier/src/utils.rs	66.66%	0 Missing and 2 partials ⚠️
crates/blockifier/src/fee/fee_checks.rs	80.00%	0 Missing and 1 partial ⚠️
crates/blockifier/src/fee/fee_utils.rs	90.90%	0 Missing and 1 partial ⚠️
crates/blockifier/src/transaction/errors.rs	0.00%	1 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff                @@
##           main-v0.13.1    #1360      +/-   ##
================================================
+ Coverage         70.43%   70.57%   +0.13%     
================================================
  Files                59       59              
  Lines              7713     7754      +41     
  Branches           7713     7754      +41     
================================================
+ Hits               5433     5472      +39     
- Misses             1853     1854       +1     
- Partials            427      428       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ArniStarkware]

crates/blockifier/src/fee/actual_cost.rs line 144 at r2 (raw file):

            true => calculate_tx_blob_gas_usage(state_changes_count),
            false => 0,
        };

I am confused.

Maybe there is a mistake in the previous commit?

Suggestion:

        # We return the blob_gas here?
        let (l1_gas_usage, _l1_blob_gas_usage) = calculate_tx_gas_and_blob_gas_usage(
            non_optional_call_infos,
            state_changes_count,
            self.l1_payload_size,
            self.block_context.block_info.use_kzg_da,
        )?;
        # We also return the blob gas here?
        let l1_blob_gas_usage = match self.block_context.block_info.use_kzg_da {
            true => calculate_tx_blob_gas_usage(state_changes_count),
            false => 0,
        };

[ArniStarkware]

Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @aner-starkware)

---

crates/blockifier/src/fee/actual_cost.rs line 144 at r2 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

I am confused.

Maybe there is a mistake in the previous commit?

There is no need to call calculate_tx_blob_gas_usage. It happens inside calculate_tx_gas_and_blob_gas_usage in your last PR.

[dorimedini-starkware]

Reviewed 1 of 4 files at r6, 1 of 5 files at r8, 6 of 6 files at r11, 1 of 1 files at r12, all commit messages.
Reviewable status: all files reviewed, 28 unresolved discussions (waiting on @aner-starkware)

---

crates/blockifier/src/utils.rs line 50 at r12 (raw file):

pub fn u128_from_usize(val: usize) -> Result<u128, String> {
    val.try_into().map_err(|_| format!("Error converting value {val} to u128."))
}

1. I want the error string to be defined where the function is called, not in the function implementation itself, so the error string can be specific (usize_from_u128 doesn't know if it's input is a gas price, a fee, or what).
2. The return type Result<u128, TryFromIntError> was just fine, no need to add map_err

Code quote:

/// Conversion from usize to u128. Currently, usize has 64 bits, so this conversion should never
/// fail.
pub fn usize_from_u128(val: u128) -> Result<usize, String> {
    val.try_into().map_err(|_| format!("Error converting value {val} to usize."))
}

/// Conversion from u128 to usize. This conversion should only be used if the value came from a
/// usize.
pub fn u128_from_usize(val: usize) -> Result<u128, String> {
    val.try_into().map_err(|_| format!("Error converting value {val} to u128."))
}

---

crates/blockifier/src/fee/fee_utils.rs line 76 at r11 (raw file):

        gas_usage: total_l1_gas_usage.ceil() as u128,
        blob_gas_usage: u128_from_usize(l1_blob_gas_usage)
            .expect("Conversion from usize to u128 should not fail."),

I want to see l1_blob_gas_usage in the output

Code quote:

.expect("Conversion from usize to u128 should not fail."),

---

crates/blockifier/src/fee/gas_usage.rs line 36 at r11 (raw file):

            use_kzg_da,
        )?)
        .expect("Conversion from usize to u128 should not fail."),

please print out all four inputs to calculate_tx_gas_usage in the error string

Code quote:

.expect("Conversion from usize to u128 should not fail."),

---

crates/blockifier/src/fee/gas_usage.rs line 41 at r11 (raw file):

            use_kzg_da,
        ))
        .expect("Conversion from usize to u128 should not fail."),

print out inputs (state changes count and KZG DA flag) in the failure string

Code quote:

.expect("Conversion from usize to u128 should not fail."),

---

crates/blockifier/src/fee/gas_usage.rs line 45 at r11 (raw file):

}

/// Returns the blob-gas (data-gas) needed to publish the transaction's state diff in a blob.

suggestion

Suggestion:

/// Returns the blob-gas (data-gas) needed to publish the transaction's state diff (if use_kzg_da is
/// false, zero blob is needed).

---

crates/blockifier/src/fee/gas_usage.rs line 61 at r11 (raw file):

/// the verifier following the addition of a transaction with the given parameters to a batch; e.g.,
/// a message from L2 to L1 is followed by a storage write operation in Starknet L1 contract which
/// requires gas.

close paren

Suggestion:

/// Returns an estimation of the L1 gas amount that will be used (by Starknet's state update and
/// the verifier following the addition of a transaction with the given parameters to a batch; e.g.,
/// a message from L2 to L1 is followed by a storage write operation in Starknet L1 contract which
/// requires gas).

---

crates/blockifier/src/fee/gas_usage_test.rs line 117 at r11 (raw file):

        u128_from_usize(manual_sharp_blob_gas_usage).unwrap(),
        deploy_account_blob_gas_usage
    );

suggestion (you may need to add some derives to GasAndBlobGasUsages)

Suggestion:

    assert_eq!(
        GasAndBlobGasUsages {
            gas_usage: u128_from_usize(manual_starknet_gas_usage + manual_sharp_gas_usage).unwrap(),
            blob_gas_usage: u128_from_usize(manual_sharp_blob_gas_usage).unwrap(),
        },
        deploy_account_gas_and_blob_gas_usage
    );

---

crates/blockifier/src/fee/gas_usage_test.rs line 132 at r11 (raw file):

        gas_usage: l1_handler_gas_usage,
        blob_gas_usage: l1_handler_blob_gas_usage,
    } = l1_handler_gas_and_blob_gas_usage;

if you only need the destructuring for the assert_eq!s below, consider comparing GasAndBlobGasUsages object instances directly (see above comment).

Code quote:

    let GasAndBlobGasUsages {
        gas_usage: l1_handler_gas_usage,
        blob_gas_usage: l1_handler_blob_gas_usage,
    } = l1_handler_gas_and_blob_gas_usage;

---

crates/blockifier/src/fee/gas_usage_test.rs line 195 at r11 (raw file):

        gas_usage: l2_to_l1_messages_gas_usage,
        blob_gas_usage: l2_to_l1_messages_blob_gas_usage,
    } = l2_to_l1_messages_gas_and_blob_gas_usage;

consider object comparison (see above)

Code quote:

    let GasAndBlobGasUsages {
        gas_usage: l2_to_l1_messages_gas_usage,
        blob_gas_usage: l2_to_l1_messages_blob_gas_usage,
    } = l2_to_l1_messages_gas_and_blob_gas_usage;

---

crates/blockifier/src/fee/gas_usage_test.rs line 208 at r11 (raw file):

            true => 0,
            false => get_onchain_data_cost(l2_to_l1_state_changes_count),
        };

will this be less lines...? non-blocking

Suggestion:

        + if use_kzg_da { 0 } else { get_onchain_data_cost(l2_to_l1_state_changes_count) };

---

crates/blockifier/src/fee/gas_usage_test.rs line 241 at r11 (raw file):

        gas_usage: storage_writings_gas_usage,
        blob_gas_usage: storage_writings_blob_gas_usage,
    } = storage_writings_gas_and_blob_gas_usage;

consider manual object comparison (see above)

Code quote:

    let GasAndBlobGasUsages {
        gas_usage: storage_writings_gas_usage,
        blob_gas_usage: storage_writings_blob_gas_usage,
    } = storage_writings_gas_and_blob_gas_usage;

---

crates/blockifier/src/fee/gas_usage_test.rs line 282 at r11 (raw file):

            eth_gas_constants::GAS_PER_MEMORY_WORD - eth_gas_constants::get_calldata_word_cost(12)
        }
    };

consider this (if formatter makes it nicer than how it currently is)

Suggestion:

    let fee_balance_discount = if use_kzg_da {
        0
    } else {
        eth_gas_constants::GAS_PER_MEMORY_WORD - eth_gas_constants::get_calldata_word_cost(12)
    };

---

crates/blockifier/src/transaction/transaction_utils.rs line 28 at r11 (raw file):

) -> TransactionExecutionResult<ResourcesMapping> {
    let l1_gas_usage = usize_from_u128(l1_gas_usages.gas_usage)
        .expect("This conversion should not fail as the value is a converted usize.");

print out the gas usage

Code quote:

.expect("This conversion should not fail as the value is a converted usize.");

---

crates/blockifier/src/transaction/transaction_utils.rs line 30 at r11 (raw file):

        .expect("This conversion should not fail as the value is a converted usize.");
    let l1_blob_gas_usage = usize_from_u128(l1_gas_usages.blob_gas_usage)
        .expect("This conversion should not fail as the value is a converted usize.");

print out the blob gas usage

Code quote:

.expect("This conversion should not fail as the value is a converted usize.")

---

crates/blockifier/src/transaction/transactions_test.rs line 296 at r11 (raw file):

}

#[rstest]

thanks for this refactor... I hate test_case

---

crates/blockifier/src/transaction/transactions_test.rs line 1093 at r11 (raw file):

    #[values(false, true)] use_kzg_da: bool,
) {
    let block_context = &&BlockContext::create_for_account_testing_with_kzg(use_kzg_da);

why extra &?

Code quote:

&

---

crates/blockifier/src/transaction/transactions_test.rs line 1205 at r11 (raw file):

    #[values(false, true)] use_kzg_da: bool,
) {
    let block_context = &&BlockContext::create_for_account_testing_with_kzg(use_kzg_da);

why extra &?

Code quote:

&

---

crates/blockifier/src/transaction/transactions_test.rs line 1491 at r11 (raw file):

    let account_cairo_version = CairoVersion::Cairo0;
    let test_contract_cairo_version = CairoVersion::Cairo0;
    let block_context = &&BlockContext::create_for_account_testing_with_kzg(use_kzg_da);

why extra &?

Code quote:

&

---

crates/blockifier/src/transaction/transactions_test.rs line 1530 at r11 (raw file):

        u128_from_usize(tx_execution_info.actual_resources.blob_gas_usage()).unwrap(),
        l1_blob_gas_usage
    );

consider using object comparison instead of destructuring (see above)

Code quote:

    let GasAndBlobGasUsages { gas_usage: l1_gas_usage, blob_gas_usage: l1_blob_gas_usage } =
        l1_gas_and_blob_gas_usage;
    assert_eq!(
        u128_from_usize(tx_execution_info.actual_resources.gas_usage()).unwrap(),
        l1_gas_usage
    );
    assert_eq!(
        u128_from_usize(tx_execution_info.actual_resources.blob_gas_usage()).unwrap(),
        l1_blob_gas_usage
    );

---

crates/blockifier/src/transaction/transactions_test.rs line 1581 at r11 (raw file):

        l1_blob_gas_usage
    );
}

consider object comparison

Code quote:

    let GasAndBlobGasUsages { gas_usage: l1_gas_usage, blob_gas_usage: l1_blob_gas_usage } =
        l1_gas_and_blob_gas_usage;
    assert_eq!(
        u128_from_usize(tx_execution_info.actual_resources.gas_usage()).unwrap(),
        l1_gas_usage
    );
    assert_eq!(
        u128_from_usize(tx_execution_info.actual_resources.blob_gas_usage()).unwrap(),
        l1_blob_gas_usage
    );
}

---

crates/blockifier/src/transaction/transactions_test.rs line 1700 at r11 (raw file):

fn test_l1_handler(#[values(false, true)] use_kzg_da: bool) {
    let state = &mut create_test_state();
    let block_context = &&BlockContext::create_for_account_testing_with_kzg(use_kzg_da);

why extra &?

Code quote:

&

[aner-starkware]

crates/blockifier/src/utils.rs line 50 at r12 (raw file):

Previously, dorimedini-starkware wrote…

1. I want the error string to be defined where the function is called, not in the function implementation itself, so the error string can be specific (usize_from_u128 doesn't know if it's input is a gas price, a fee, or what).
2. The return type Result<u128, TryFromIntError> was just fine, no need to add map_err

OK, but then you don't have the value (it's not part of the error).

[aner-starkware]

crates/blockifier/src/fee/fee_utils.rs line 76 at r11 (raw file):

Previously, dorimedini-starkware wrote…

I want to see l1_blob_gas_usage in the output

It's shown because the error contains the value. I think it's better to put a TODO here until you figure out exactly what it is we want.

[dorimedini-starkware]

Reviewed 12 of 12 files at r13, all commit messages.
Reviewable status: all files reviewed, 24 unresolved discussions (waiting on @aner-starkware)

[ArniStarkware]

crates/blockifier/src/transaction/transaction_utils.rs line 30 at r13 (raw file):

        .expect("This conversion should not fail as the value is a converted usize.");
    let l1_blob_gas_usage = usize_from_u128(l1_gas_usages.blob_gas)
        .expect("This conversion should not fail as the value is a converted usize.");

@dorimedini-starkware Why not?
What am I missing?

Suggestion:

    let l1_blob_gas_usage = l1_gas_usages.blob_gas.try_into()
        .expect("This conversion should not fail as the value is a converted usize.");

[dorimedini-starkware]

Reviewable status: all files reviewed, 20 unresolved discussions (waiting on @aner-starkware and @ArniStarkware)

---

crates/blockifier/src/utils.rs line 50 at r12 (raw file):

Previously, aner-starkware wrote…

OK, but then you don't have the value (it's not part of the error).

good point. too bad TryFromIntError doesn't include it.
however, String is not really a good option (not an Error enum); how about a NumericConversionError?

---

crates/blockifier/src/fee/fee_utils.rs line 76 at r11 (raw file):

Previously, aner-starkware wrote…

It's shown because the error contains the value. I think it's better to put a TODO here until you figure out exactly what it is we want.

right, this is fine how it is :) no need for TODO

---

crates/blockifier/src/fee/gas_usage.rs line 36 at r11 (raw file):

Previously, dorimedini-starkware wrote…

please print out all four inputs to calculate_tx_gas_usage in the error string

nvm

---

crates/blockifier/src/fee/gas_usage.rs line 41 at r11 (raw file):

Previously, dorimedini-starkware wrote…

print out inputs (state changes count and KZG DA flag) in the failure string

nvm

---

crates/blockifier/src/transaction/transaction_utils.rs line 28 at r11 (raw file):

Previously, dorimedini-starkware wrote…

print out the gas usage

nvm

---

crates/blockifier/src/transaction/transaction_utils.rs line 30 at r11 (raw file):

Previously, dorimedini-starkware wrote…

print out the blob gas usage

nvm

---

crates/blockifier/src/transaction/transaction_utils.rs line 30 at r13 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

@dorimedini-starkware Why not?
What am I missing?

in case the type of blob_gas changes in the future, and the behavior of try_into will silently change. using usize_from_u128 ensures we get compile-time errors if the underlying type changes

[aner-starkware]

Reviewable status: 13 of 15 files reviewed, 19 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

crates/blockifier/src/utils.rs line 50 at r12 (raw file):

Previously, dorimedini-starkware wrote…

good point. too bad TryFromIntError doesn't include it.
however, String is not really a good option (not an Error enum); how about a NumericConversionError?

Done.

---

crates/blockifier/src/fee/fee_utils.rs line 95 at r10 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Sorry, I meant this:

pub struct GasVector { 
        pub l1_gas: u128, 
        pub blob_gas: u128, 
        // (In the future:) 
        pub l2_gas: u128, 
}

Done.

---

crates/blockifier/src/fee/gas_usage.rs line 34 at r9 (raw file):

Previously, dorimedini-starkware wrote…

function should return result, use unwrap_or_else(|_| panic!(<MESSAGE>)) where the message is informative

OK. Used expect.

---

crates/blockifier/src/fee/gas_usage.rs line 60 at r10 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

.

Done.

---

crates/blockifier/src/fee/gas_usage.rs line 66 at r10 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

.

Done.

---

crates/blockifier/src/fee/gas_usage.rs line 67 at r10 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

.

Done.

---

crates/blockifier/src/fee/gas_usage.rs line 103 at r10 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Ignore the Ignore

Done.

---

crates/blockifier/src/transaction/transactions_test.rs line 1093 at r11 (raw file):

Previously, dorimedini-starkware wrote…

why extra &?

Done.

---

crates/blockifier/src/transaction/transactions_test.rs line 1205 at r11 (raw file):

Previously, dorimedini-starkware wrote…

why extra &?

Done.

---

crates/blockifier/src/transaction/transactions_test.rs line 1700 at r11 (raw file):

Previously, dorimedini-starkware wrote…

why extra &?

Done.

[aner-starkware]

Reviewable status: 12 of 15 files reviewed, 19 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

crates/blockifier/src/fee/gas_usage.rs line 59 at r10 (raw file):

/// the verifier following the addition of a transaction with the given parameters to a batch; e.g.,
/// a message from L2 to L1 is followed by a storage write operation in Starknet L1 contract which
/// requires gas.

Done.

---

crates/blockifier/src/fee/gas_usage.rs line 61 at r11 (raw file):

Previously, dorimedini-starkware wrote…

close paren

Done.

[dorimedini-starkware]

Reviewed 2 of 2 files at r14, 1 of 1 files at r15, all commit messages.
Reviewable status: all files reviewed, 19 unresolved discussions (waiting on @aner-starkware and @Yoni-Starkware)

---

crates/blockifier/src/fee/gas_usage.rs line 36 at r15 (raw file):

            use_kzg_da,
        )?)
        .expect("Conversion from usize to u128 should not fail."),

Suggestion:

"Result of calculate_tx_l1_gas_usage failed conversion to u128."

---

crates/blockifier/src/fee/gas_usage.rs line 38 at r15 (raw file):

        .expect("Conversion from usize to u128 should not fail."),
        blob_gas: u128_from_usize(calculate_tx_blob_gas_usage(state_changes_count, use_kzg_da))
            .expect("Conversion from usize to u128 should not fail."),

Suggestion:

"Result of calculate_tx_blob_gas_usage failed conversion to u128."

[aner-starkware]

Reviewable status: all files reviewed, 19 unresolved discussions (waiting on @dorimedini-starkware and @Yoni-Starkware)

---

crates/blockifier/src/fee/gas_usage.rs line 77 at r10 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

.

Done.

---

crates/blockifier/src/fee/gas_usage.rs line 36 at r15 (raw file):

            use_kzg_da,
        )?)
        .expect("Conversion from usize to u128 should not fail."),

Done. Although I personally disagree here - I think the message should explain why we expect it to pass, not to inform what failed.

---

crates/blockifier/src/fee/gas_usage.rs line 38 at r15 (raw file):

        .expect("Conversion from usize to u128 should not fail."),
        blob_gas: u128_from_usize(calculate_tx_blob_gas_usage(state_changes_count, use_kzg_da))
            .expect("Conversion from usize to u128 should not fail."),

Done. Same comment as above.

---

crates/blockifier/src/fee/gas_usage_test.rs line 117 at r11 (raw file):

Previously, dorimedini-starkware wrote…

suggestion (you may need to add some derives to GasAndBlobGasUsages)

Added TODO.

---

crates/blockifier/src/fee/gas_usage_test.rs line 132 at r11 (raw file):

Previously, dorimedini-starkware wrote…

if you only need the destructuring for the assert_eq!s below, consider comparing GasAndBlobGasUsages object instances directly (see above comment).

Added TODO.

---

crates/blockifier/src/fee/gas_usage_test.rs line 195 at r11 (raw file):

Previously, dorimedini-starkware wrote…

consider object comparison (see above)

Added TODO

---

crates/blockifier/src/fee/gas_usage_test.rs line 208 at r11 (raw file):

Previously, dorimedini-starkware wrote…

will this be less lines...? non-blocking

Added TODO

---

crates/blockifier/src/fee/gas_usage_test.rs line 241 at r11 (raw file):

Previously, dorimedini-starkware wrote…

consider manual object comparison (see above)

Added TODO

---

crates/blockifier/src/fee/gas_usage_test.rs line 282 at r11 (raw file):

Previously, dorimedini-starkware wrote…

consider this (if formatter makes it nicer than how it currently is)

Added TODO

---

crates/blockifier/src/transaction/transactions_test.rs line 1530 at r11 (raw file):

Previously, dorimedini-starkware wrote…

consider using object comparison instead of destructuring (see above)

Added TODO

---

crates/blockifier/src/transaction/transactions_test.rs line 1581 at r11 (raw file):

Previously, dorimedini-starkware wrote…

consider object comparison

Added TODO

[dorimedini-starkware]

Reviewed 2 of 2 files at r16, all commit messages.
Reviewable status: all files reviewed, 8 unresolved discussions (waiting on @aner-starkware and @Yoni-Starkware)

---

crates/blockifier/src/fee/gas_usage.rs line 36 at r15 (raw file):

Previously, aner-starkware wrote…

Done. Although I personally disagree here - I think the message should explain why we expect it to pass, not to inform what failed.

Sure, I didn't mean to insist on grammar, just wanted calculate_tx_l1_gas_usage to appear in the string.
Same as below

[Yoni-Starkware]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @aner-starkware)

---

crates/blockifier/src/transaction/account_transaction.rs line 181 at r16 (raw file):

    ) -> TransactionPreValidationResult<()> {
        // TODO(Aner, 21/01/24) modify for 4844 (blob_gas).
        let minimal_l1_gas_and_blob_gas_amount = estimate_minimal_l1_gas(block_context, self)?;

Non-blocking for this PR

Suggestion:

let minimal_gas_vector = estimate_minimal_gas_vector(block_context, self)?;

---

crates/blockifier/src/transaction/account_transaction.rs line 215 at r16 (raw file):

            AccountTransactionContext::Deprecated(context) => {
                let max_fee = context.max_fee;
                let min_fee = get_fee_by_l1_gas_usages(

Non-blocking for this PR

Suggestion:

get_fee_by_gas_vector

[aner-starkware]

crates/blockifier/src/transaction/account_transaction.rs line 181 at r16 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Non-blocking for this PR

OK. There's a TODO, and we should verify that there isn't any logic that should be changed as well here (specifically, it seems that the function estimate\_minimal\_l1\_gas should be modified for 4844)

[aner-starkware]

crates/blockifier/src/transaction/account_transaction.rs line 215 at r16 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Non-blocking for this PR

But it's a blocking comment :)

[dorimedini-starkware]

Reviewed 7 of 7 files at r17, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @aner-starkware and @Yoni-Starkware)

[Yoni-Starkware]

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware)

[aner-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion

a discussion (no related file):
Let me know if there's anything else

---

[Yoni-Starkware]

Reviewed 3 of 12 files at r13, 3 of 7 files at r17.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware)

[Yoni-Starkware]

Reviewed 1 of 12 files at r13, 1 of 7 files at r17.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aner-starkware)

---

crates/blockifier/src/transaction/transaction_utils.rs line 23 at r17 (raw file):

pub fn calculate_tx_resources(
    execution_resources: &ExecutionResources,
    l1_gas_usages: GasVector,

In the next PR, please rename things like this to gas_vector (also in func names)

Code quote:

l1_gas_usages

[dorimedini-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @aner-starkware)