Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First Draft - Access Control for Function Call Delegation #110

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

jbettenc
Copy link
Contributor

@jbettenc jbettenc commented Oct 2, 2024

This SNIP aims to introduce access control standards to allow linking wallets together, permitting an external wallet to perform specified smart contract actions on behalf of a primary wallet, with varying levels of restriction.

@boyuanx
Copy link
Contributor

boyuanx commented Oct 3, 2024

@boyuanx
Copy link
Contributor

boyuanx commented Oct 3, 2024

Any feedback is welcome, especially the reference implementation stuff regarding hashes, let me know if the code looks incorrect!

Copy link

github-actions bot commented Nov 3, 2024

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 3, 2024
@jbettenc
Copy link
Contributor Author

jbettenc commented Nov 3, 2024

bump

Copy link

github-actions bot commented Dec 4, 2024

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Dec 4, 2024
@boyuanx
Copy link
Contributor

boyuanx commented Dec 4, 2024

@leo-starkware Hi! What are the next steps for us?

@leo-starkware
Copy link
Collaborator

@boyuanx Hey, sorry for the delays. Can you:

  1. Change to SNIP-26 everywhere where XXX is written? As well as the title of the md.
  2. Fill in the "Security consideration" section, saying that there are none if that's the case.

@jbettenc
Copy link
Contributor Author

jbettenc commented Dec 4, 2024

Hey @leo-starkware, I have updated the SNIP number. The subsection labeled Offchain Permit Revocations belongs under the Security Considerations section. Is there some way that you would prefer the markdown to look to make this more clear?

@leo-starkware
Copy link
Collaborator

@jbettenc Last request before merge: can you add to the header the link to the forum post? field discussions-to

@jbettenc
Copy link
Contributor Author

jbettenc commented Dec 5, 2024

@leo-starkware Just added 👍

@leo-starkware leo-starkware merged commit 6956cb9 into starknet-io:main Dec 6, 2024
@boyuanx boyuanx deleted the draft/acdelegation branch December 6, 2024 09:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants