Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Immutable Component Config (SRC-107) #107

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ericnordelo
Copy link
Contributor

@ericnordelo ericnordelo commented Aug 20, 2024

Discussion:

https://community.starknet.io/t/immutable-component-config/114434

Abstract

This standard proposes a mechanism to allow setting components’ configurable constants in the implementing contracts
without needing to save them in storage. Component providers can leverage this standard to make them configurable while
keeping the constants hardcoded in the bytecode, removing the extra storage reads required if storage were to be used for
this matter.

SNIP number

I followed the PR number pattern to assign 107.

@ericnordelo ericnordelo changed the title Immutable Component Config Immutable Component Config (SRC-107) Aug 23, 2024
Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 23, 2024
@ericnordelo
Copy link
Contributor Author

@amanusk If I recall correctly you are also a maintainer of this repo now? tagging you for review in case that is correct. cc @ArielElp

@github-actions github-actions bot removed the stale label Sep 24, 2024
@leo-starkware
Copy link
Collaborator

Hey @ericnordelo can you add the mandatory section "Rationale" (IMO you could simply rename the section "Motivation" which is optional) and "Security considerations"?
Also tagging @ArielElp in case there are comments to address before merging to main

@ericnordelo
Copy link
Contributor Author

Hey @leo-starkware, sorry for the delay. Updates applied!

Copy link
Collaborator

@leo-starkware leo-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the file name to "snip-23", as well as in line 2 "snip: 23". After that let's merge

@ericnordelo
Copy link
Contributor Author

What is the rationale behind the 23? It is not easier to track SNIPs by the PR number (like EIPs) so they can be safely referenced when they are drafts? We are also already referencing this in the library as SRC-107.

Copy link

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants