Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update StarcoinFramework for DAO Space #3564

Merged
merged 3 commits into from
Jul 30, 2022
Merged

Update StarcoinFramework for DAO Space #3564

merged 3 commits into from
Jul 30, 2022

Conversation

jolestar
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@jolestar jolestar marked this pull request as draft July 26, 2022 09:57
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #3564 (a37e339) into master (f71484d) will increase coverage by 0.09%.
The diff coverage is 31.58%.

❗ Current head a37e339 differs from pull request most recent head f410bec. Consider uploading reports for the commit f410bec to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3564      +/-   ##
==========================================
+ Coverage   29.20%   29.28%   +0.09%     
==========================================
  Files         589      589              
  Lines       49790    49792       +2     
  Branches    23419    23434      +15     
==========================================
+ Hits        14535    14576      +41     
- Misses      20849    21139     +290     
+ Partials    14406    14077     -329     
Flag Coverage Δ
unittests 29.28% <31.58%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sync/src/block_connector/test_illegal_block.rs 17.57% <0.00%> (-2.60%) ⬇️
sync/src/block_connector/test_write_block_chain.rs 30.24% <0.00%> (-1.55%) ⬇️
sync/src/tasks/tests.rs 15.84% <0.00%> (ø)
cmd/starcoin/src/dev/tests.rs 14.20% <44.45%> (-0.42%) ⬇️
vm/stdlib/src/lib.rs 22.55% <50.00%> (ø)
vm/vm-runtime/src/errors.rs 29.69% <100.00%> (ø)
vm/types/src/language_storage_ext.rs 29.17% <0.00%> (-12.50%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 35.00% <0.00%> (-10.00%) ⬇️
network-p2p/src/transport.rs 15.10% <0.00%> (-9.43%) ⬇️
vm/types/src/transaction_metadata.rs 55.23% <0.00%> (-8.95%) ⬇️
... and 82 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6de02c7...f410bec. Read the comment docs.

@github-actions
Copy link

Benchmark for 0fad136

Click to view benchmark
Test Base PR %
accumulator_append 600.1±10.98µs 601.9±9.60µs +0.30%
block_apply/block_apply_10 266.1±1.03ms 627.1±0.72ms +135.66%
block_apply/block_apply_1000 27.0±0.04s 64.1±0.04s +137.41%
get_with_proof/db_store 36.8±0.66µs 36.7±0.19µs -0.27%
get_with_proof/mem_store 31.7±0.17µs 31.4±0.19µs -0.95%
put_and_commit/db_store/1 95.1±4.71µs 94.7±4.88µs -0.42%
put_and_commit/db_store/10 850.4±38.17µs 849.3±38.72µs -0.13%
put_and_commit/db_store/100 7.3±0.32ms 7.3±0.31ms 0.00%
put_and_commit/db_store/5 433.5±22.06µs 433.5±21.02µs 0.00%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.6±5.84µs 62.0±5.64µs +0.65%
put_and_commit/mem_store/10 578.6±48.01µs 578.2±48.80µs -0.07%
put_and_commit/mem_store/100 5.7±0.84ms 5.6±0.82ms -1.75%
put_and_commit/mem_store/5 292.2±24.09µs 292.5±25.41µs +0.10%
put_and_commit/mem_store/50 2.8±0.19ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.12ms 5.4±0.16ms +38.46%
query_block/query_block_in(10)_times(1000) 39.2±0.73ms 54.3±1.56ms +38.52%
query_block/query_block_in(10)_times(10000) 388.9±7.75ms 535.5±12.61ms +37.70%
query_block/query_block_in(1000)_times(100) 947.8±5.84µs 975.5±13.30µs +2.92%
query_block/query_block_in(1000)_times(1000) 9.5±0.11ms 9.8±0.09ms +3.16%
query_block/query_block_in(1000)_times(10000) 94.9±0.62ms 96.8±0.77ms +2.00%
storage_transaction 1051.9±275.47µs 1038.3±270.07µs -1.29%
vm/transaction_execution/1 312.2±1.81ms 705.5±2.03ms +125.98%
vm/transaction_execution/10 98.0±0.08ms 175.9±0.94ms +79.49%
vm/transaction_execution/20 91.4±0.17ms 151.1±0.51ms +65.32%
vm/transaction_execution/5 119.7±0.27ms 231.8±0.47ms +93.65%
vm/transaction_execution/50 106.1±0.68ms 165.7±0.87ms +56.17%

@github-actions
Copy link

Benchmark for 648412f

Click to view benchmark
Test Base PR %
accumulator_append 600.5±15.96µs 598.3±11.21µs -0.37%
block_apply/block_apply_10 264.7±0.57ms 633.0±1.21ms +139.14%
block_apply/block_apply_1000 27.1±0.03s 64.3±0.03s +137.27%
get_with_proof/db_store 36.4±0.27µs 36.2±0.27µs -0.55%
get_with_proof/mem_store 31.5±0.19µs 31.5±0.33µs 0.00%
put_and_commit/db_store/1 95.5±4.91µs 95.8±4.99µs +0.31%
put_and_commit/db_store/10 859.0±41.01µs 851.9±39.05µs -0.83%
put_and_commit/db_store/100 7.4±0.30ms 7.3±0.31ms -1.35%
put_and_commit/db_store/5 439.2±22.31µs 438.0±23.96µs -0.27%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.18ms 0.00%
put_and_commit/mem_store/1 62.3±5.86µs 62.0±5.72µs -0.48%
put_and_commit/mem_store/10 577.9±46.47µs 580.8±50.29µs +0.50%
put_and_commit/mem_store/100 5.6±0.34ms 5.7±0.82ms +1.79%
put_and_commit/mem_store/5 291.8±24.85µs 293.5±26.04µs +0.58%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.19ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.09ms 5.4±0.24ms +38.46%
query_block/query_block_in(10)_times(1000) 38.0±2.25ms 53.8±1.56ms +41.58%
query_block/query_block_in(10)_times(10000) 388.2±6.21ms 546.0±10.55ms +40.65%
query_block/query_block_in(1000)_times(100) 938.0±10.12µs 971.1±12.22µs +3.53%
query_block/query_block_in(1000)_times(1000) 9.3±0.09ms 9.6±0.12ms +3.23%
query_block/query_block_in(1000)_times(10000) 93.5±0.59ms 96.5±0.92ms +3.21%
storage_transaction 1076.7±343.86µs 1044.6±283.43µs -2.98%
vm/transaction_execution/1 314.0±0.99ms 709.6±1.82ms +125.99%
vm/transaction_execution/10 99.8±2.14ms 177.4±1.49ms +77.76%
vm/transaction_execution/20 92.4±0.15ms 153.7±3.18ms +66.34%
vm/transaction_execution/5 120.7±0.25ms 233.3±0.42ms +93.29%
vm/transaction_execution/50 107.0±0.85ms 166.9±0.37ms +55.98%

@github-actions
Copy link

Benchmark for 60a0735

Click to view benchmark
Test Base PR %
accumulator_append 604.9±27.40µs 602.9±30.27µs -0.33%
block_apply/block_apply_10 265.9±1.05ms 630.4±0.59ms +137.08%
block_apply/block_apply_1000 27.2±0.05s 64.2±0.05s +136.03%
get_with_proof/db_store 36.6±0.51µs 36.6±0.15µs 0.00%
get_with_proof/mem_store 31.6±0.19µs 31.6±0.17µs 0.00%
put_and_commit/db_store/1 96.6±5.00µs 96.9±4.89µs +0.31%
put_and_commit/db_store/10 859.8±39.60µs 861.6±39.53µs +0.21%
put_and_commit/db_store/100 7.3±0.30ms 7.4±0.28ms +1.37%
put_and_commit/db_store/5 441.1±22.48µs 441.6±21.92µs +0.11%
put_and_commit/db_store/50 3.8±0.17ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 62.0±5.72µs 61.6±5.70µs -0.65%
put_and_commit/mem_store/10 579.6±47.34µs 579.4±47.22µs -0.03%
put_and_commit/mem_store/100 5.7±0.83ms 5.7±0.84ms 0.00%
put_and_commit/mem_store/5 294.9±25.97µs 290.7±24.45µs -1.42%
put_and_commit/mem_store/50 2.9±0.18ms 2.9±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.09ms 5.4±0.13ms +38.46%
query_block/query_block_in(10)_times(1000) 39.0±0.71ms 54.8±1.54ms +40.51%
query_block/query_block_in(10)_times(10000) 389.2±5.04ms 540.0±15.43ms +38.75%
query_block/query_block_in(1000)_times(100) 966.5±9.05µs 987.2±13.17µs +2.14%
query_block/query_block_in(1000)_times(1000) 9.6±0.06ms 9.9±0.14ms +3.13%
query_block/query_block_in(1000)_times(10000) 95.9±0.47ms 98.5±0.99ms +2.71%
storage_transaction 1106.8±347.87µs 1077.0±282.77µs -2.69%
vm/transaction_execution/1 313.3±0.89ms 718.3±6.92ms +129.27%
vm/transaction_execution/10 99.1±0.12ms 180.9±5.76ms +82.54%
vm/transaction_execution/20 92.3±0.18ms 153.1±0.61ms +65.87%
vm/transaction_execution/5 120.9±0.79ms 235.6±1.26ms +94.87%
vm/transaction_execution/50 106.9±0.24ms 167.6±0.40ms +56.78%

@github-actions
Copy link

Benchmark for f89f40e

Click to view benchmark
Test Base PR %
accumulator_append 606.5±14.45µs 602.1±9.46µs -0.73%
block_apply/block_apply_10 265.7±0.48ms 636.3±2.20ms +139.48%
block_apply/block_apply_1000 27.2±0.08s 65.0±0.14s +138.97%
get_with_proof/db_store 37.2±0.66µs 36.5±0.34µs -1.88%
get_with_proof/mem_store 31.5±0.18µs 31.7±0.21µs +0.63%
put_and_commit/db_store/1 96.3±4.86µs 97.1±6.33µs +0.83%
put_and_commit/db_store/10 853.7±40.01µs 861.4±37.17µs +0.90%
put_and_commit/db_store/100 7.4±0.29ms 7.4±0.41ms 0.00%
put_and_commit/db_store/5 441.7±22.23µs 443.8±22.19µs +0.48%
put_and_commit/db_store/50 3.8±0.19ms 3.8±0.16ms 0.00%
put_and_commit/mem_store/1 61.7±5.66µs 62.0±5.79µs +0.49%
put_and_commit/mem_store/10 575.3±47.79µs 576.7±47.33µs +0.24%
put_and_commit/mem_store/100 5.7±0.83ms 5.7±0.84ms 0.00%
put_and_commit/mem_store/5 290.8±24.94µs 290.8±24.32µs 0.00%
put_and_commit/mem_store/50 2.9±0.19ms 2.8±0.19ms -3.45%
query_block/query_block_in(10)_times(100) 3.9±0.10ms 5.4±0.30ms +38.46%
query_block/query_block_in(10)_times(1000) 39.3±0.62ms 53.6±1.64ms +36.39%
query_block/query_block_in(10)_times(10000) 387.5±5.78ms 542.9±19.52ms +40.10%
query_block/query_block_in(1000)_times(100) 940.7±4.31µs 968.0±6.26µs +2.90%
query_block/query_block_in(1000)_times(1000) 9.4±0.06ms 9.7±0.08ms +3.19%
query_block/query_block_in(1000)_times(10000) 94.2±0.50ms 99.0±5.02ms +5.10%
storage_transaction 1081.1±305.02µs 1102.7±348.78µs +2.00%
vm/transaction_execution/1 313.8±0.67ms 711.2±2.42ms +126.64%
vm/transaction_execution/10 99.1±0.13ms 177.4±0.64ms +79.01%
vm/transaction_execution/20 92.5±0.14ms 153.3±1.07ms +65.73%
vm/transaction_execution/5 120.9±0.39ms 234.5±1.06ms +93.96%
vm/transaction_execution/50 106.8±0.20ms 167.4±0.32ms +56.74%

@jolestar jolestar marked this pull request as ready for review July 29, 2022 08:44
@jolestar
Copy link
Member Author

一些测试用例变慢了,但没有仔细研究原因,按道理升级 starcoin-framework 不应该影响测试用例的用时。记录了一个 issue #3581 追踪。

@jolestar jolestar requested review from baichuan3 and welbon July 29, 2022 10:16
@jolestar jolestar enabled auto-merge (squash) July 29, 2022 12:14
@jolestar jolestar merged commit 18a055f into master Jul 30, 2022
@jolestar jolestar deleted the dao_space branch July 30, 2022 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants