Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scmd): Fix messages printed as error wrongly #3438

Merged
merged 1 commit into from
May 31, 2022

Conversation

Xuanwo
Copy link
Contributor

@Xuanwo Xuanwo commented May 31, 2022

Signed-off-by: Xuanwo [email protected]

Fix #3423

Pull request type

Please check the type of change your PR introduces:

  • Bugfix

What is the current behavior?

:) ./target/debug/starcoin_generator --version
2022-05-31T20:52:52.593489944+08:00 ERROR - error: starcoin 1.11.10 (build:v1.11.9-alpha-20-ga43584bfc-dirty)

Issue Number: #3423

What is the new behavior?

--version:

:) ./target/debug/starcoin_generator --version
starcoin 1.11.10 (build:v1.11.9-alpha-20-ga43584bfc-dirty)

-h

:) ./target/debug/starcoin_generator -h
starcoin 1.11.10
Starcoin

USAGE:
    starcoin_generator [OPTIONS] [SUBCOMMAND]
...

Other information

None.

@jolestar jolestar enabled auto-merge (squash) May 31, 2022 13:50
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #3438 (1c51c38) into master (a43584b) will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3438      +/-   ##
==========================================
- Coverage   32.39%   32.10%   -0.29%     
==========================================
  Files         500      500              
  Lines       46805    46805              
  Branches    21301    21301              
==========================================
- Hits        15157    15021     -136     
- Misses      17531    17574      +43     
- Partials    14117    14210      +93     
Flag Coverage Δ
unittests 32.10% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commons/scmd/src/context.rs 0.00% <ø> (ø)
...m/types/src/account_config/events/config_change.rs 66.67% <0.00%> (-33.33%) ⬇️
vm/natives/src/account.rs 12.50% <0.00%> (-18.75%) ⬇️
test-helper/src/dummy_network_service.rs 22.23% <0.00%> (-14.81%) ⬇️
vm/types/src/transaction_metadata.rs 56.72% <0.00%> (-7.46%) ⬇️
state/state-tree/src/mock/mod.rs 43.48% <0.00%> (-4.34%) ⬇️
consensus/src/dummy.rs 82.61% <0.00%> (-4.34%) ⬇️
vm/natives/src/vector.rs 20.84% <0.00%> (-4.16%) ⬇️
vm/vm-runtime/src/metrics.rs 29.17% <0.00%> (-4.16%) ⬇️
vm/types/src/on_chain_config/mod.rs 50.69% <0.00%> (-4.10%) ⬇️
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a43584b...1c51c38. Read the comment docs.

@jolestar jolestar merged commit aa4d426 into starcoinorg:master May 31, 2022
@Xuanwo Xuanwo deleted the fix-error-message branch May 31, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] starcoin_generator output ERROR field in help message
2 participants