Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mpm] Fix integration tests public_keys arguments #3359

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

jolestar
Copy link
Member

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Support:

init -n dev --public-keys AKey=0x07d815b1ef166cbba8dc80e6e2f0e50e3461551ca118a6587632e615123139a6 BKey=0x3517cf661eb9ec48ad86639db66ea463b871b7d10c52bb37461570aef68f8c36 

and

init -n dev --public-keys AKey=0x07d815b1ef166cbba8dc80e6e2f0e50e3461551ca118a6587632e615123139a6 --public-keys BKey=0x3517cf661eb9ec48ad86639db66ea463b871b7d10c52bb37461570aef68f8c36 

Other information

https://discord.com/channels/822159062475997194/892760287797714954/966563936331776050

@codecov
Copy link

codecov bot commented Apr 21, 2022

Codecov Report

Merging #3359 (2b67a15) into master (4652f82) will decrease coverage by 0.25%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3359      +/-   ##
==========================================
- Coverage   32.18%   31.93%   -0.24%     
==========================================
  Files         500      500              
  Lines       46814    46815       +1     
  Branches    21311    21312       +1     
==========================================
- Hits        15063    14948     -115     
- Misses      17732    17762      +30     
- Partials    14019    14105      +86     
Flag Coverage Δ
unittests 31.93% <0.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
vm/starcoin-transactional-test-harness/src/lib.rs 0.19% <0.00%> (-<0.01%) ⬇️
test-helper/src/dummy_network_service.rs 22.23% <0.00%> (-14.81%) ⬇️
executor/src/block_executor.rs 24.45% <0.00%> (-13.33%) ⬇️
consensus/src/dummy.rs 69.57% <0.00%> (-13.04%) ⬇️
chain/src/verifier/mod.rs 36.72% <0.00%> (-11.71%) ⬇️
vm/types/src/transaction_metadata.rs 56.72% <0.00%> (-7.46%) ⬇️
consensus/src/consensus.rs 58.74% <0.00%> (-4.76%) ⬇️
vm/natives/src/token.rs 26.67% <0.00%> (-4.44%) ⬇️
commons/accumulator/src/lib.rs 58.95% <0.00%> (-4.21%) ⬇️
executor/src/executor.rs 50.00% <0.00%> (-4.16%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4652f82...2b67a15. Read the comment docs.

@nanne007 nanne007 merged commit 6ac5aab into master Apr 22, 2022
@nanne007 nanne007 deleted the fix_mpm_integration_tests branch April 22, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants