Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runner config updated, enable integration test and scaler to zero ci nodes #3317

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

yourmoonlight
Copy link
Collaborator

@yourmoonlight yourmoonlight commented Apr 6, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

  1. support cluster autoscaler scale to zero node, use k8s feature tolerations && taints
  2. fix integration test timeout issue Upgrade github runner and enable integration test #3160

checkRun:
types: ["created"]
status: "queued"
amount: 2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 amount 2 代表什么?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

对于每次回调事件,在duration时间内,启动2个runner

@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #3317 (597d693) into master (f759246) will decrease coverage by 0.43%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3317      +/-   ##
==========================================
- Coverage   32.25%   31.82%   -0.42%     
==========================================
  Files         500      500              
  Lines       46769    46769              
  Branches    21263    21262       -1     
==========================================
- Hits        15079    14880     -199     
- Misses      17662    17872     +210     
+ Partials    14028    14017      -11     
Flag Coverage Δ
unittests 31.82% <ø> (-0.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m/types/src/account_config/events/config_change.rs 66.67% <0.00%> (-33.33%) ⬇️
consensus/src/consensus.rs 42.86% <0.00%> (-15.87%) ⬇️
vm/types/src/language_storage_ext.rs 37.50% <0.00%> (-12.50%) ⬇️
vm/types/src/on_chain_config/vm_config.rs 35.00% <0.00%> (-11.66%) ⬇️
chain/open-block/src/lib.rs 31.58% <0.00%> (-9.21%) ⬇️
...ccount_config/resources/module_upgrade_strategy.rs 34.29% <0.00%> (-8.57%) ⬇️
abi/decoder/src/lib.rs 1.58% <0.00%> (-7.87%) ⬇️
commons/forkable-jellyfish-merkle/src/lib.rs 39.85% <0.00%> (-7.66%) ⬇️
types/src/account_state.rs 63.34% <0.00%> (-6.66%) ⬇️
vm/natives/src/account.rs 12.50% <0.00%> (-6.25%) ⬇️
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f759246...597d693. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Benchmark for a8a9223

Click to view benchmark
Test Base PR %
accumulator_append 589.4±10.14µs 587.2±10.34µs -0.37%
block_apply/block_apply_10 269.1±1.23ms 269.6±1.20ms +0.19%
block_apply/block_apply_1000 27.4±0.07s 27.4±0.02s 0.00%
get_with_proof/db_store 36.0±0.45µs 36.3±0.23µs +0.83%
get_with_proof/mem_store 31.2±0.30µs 31.4±0.34µs +0.64%
put_and_commit/db_store/1 94.6±4.95µs 95.6±4.84µs +1.06%
put_and_commit/db_store/10 844.6±40.00µs 857.9±37.85µs +1.57%
put_and_commit/db_store/100 7.2±0.28ms 7.3±0.31ms +1.39%
put_and_commit/db_store/5 435.1±22.47µs 438.5±20.29µs +0.78%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.18ms 0.00%
put_and_commit/mem_store/1 60.8±5.45µs 61.8±5.51µs +1.64%
put_and_commit/mem_store/10 571.2±48.57µs 579.1±45.99µs +1.38%
put_and_commit/mem_store/100 5.6±0.80ms 5.7±0.80ms +1.79%
put_and_commit/mem_store/5 289.2±24.99µs 292.5±23.76µs +1.14%
put_and_commit/mem_store/50 2.8±0.19ms 2.9±0.18ms +3.57%
query_block/query_block_in(10)_times(100) 3.9±0.18ms 3.9±0.14ms 0.00%
query_block/query_block_in(10)_times(1000) 39.0±0.81ms 38.2±1.23ms -2.05%
query_block/query_block_in(10)_times(10000) 384.5±7.07ms 381.9±9.61ms -0.68%
query_block/query_block_in(1000)_times(100) 931.4±7.63µs 938.9±5.24µs +0.81%
query_block/query_block_in(1000)_times(1000) 9.4±0.08ms 9.4±0.10ms 0.00%
query_block/query_block_in(1000)_times(10000) 93.5±0.74ms 94.1±0.31ms +0.64%
storage_transaction 1049.6±291.85µs 1082.6±342.25µs +3.14%
vm/transaction_execution/1 315.4±1.54ms 314.8±1.30ms -0.19%
vm/transaction_execution/10 98.7±0.54ms 98.9±1.09ms +0.20%
vm/transaction_execution/20 91.2±1.22ms 90.7±0.13ms -0.55%
vm/transaction_execution/5 121.1±1.15ms 122.3±4.42ms +0.99%
vm/transaction_execution/50 102.6±0.41ms 102.9±0.94ms +0.29%

@jolestar jolestar merged commit 31d48f9 into master Apr 6, 2022
@jolestar jolestar deleted the fix/runner_config_for_ci branch April 6, 2022 21:40
@jolestar jolestar linked an issue Apr 12, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade github runner and enable integration test
2 participants