Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #3309 #3314

Merged
merged 2 commits into from
Apr 6, 2022
Merged

fix #3309 #3314

merged 2 commits into from
Apr 6, 2022

Conversation

LemonHX
Copy link
Member

@LemonHX LemonHX commented Apr 6, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

bug

Issue Number: #3309

What is the new behavior?

as before

@LemonHX LemonHX self-assigned this Apr 6, 2022
@LemonHX LemonHX added the bugfix label Apr 6, 2022
Copy link
Member

@jolestar jolestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以把集成测试打开试试 #3303

tokio::runtime::Builder::new_multi_thread()
.enable_all()
.on_thread_stop(|| debug!("client-actix-system thread stopped"))
.on_thread_stop(|| println!("client-actix-system thread stopped"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议不要直接 println, 会影响命令行的输出结果。日志是输出在 stderr 中的。

@jolestar
Copy link
Member

jolestar commented Apr 6, 2022

或者这个直接 merge 进去,然后 #3303 那边 rebase 一下。

@LemonHX LemonHX merged commit f759246 into starcoinorg:master Apr 6, 2022
@jolestar jolestar linked an issue Apr 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: life time error when update actix and tokio
2 participants