Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove clippy_vec_init_and_push and dup code #3311

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

nkysg
Copy link
Collaborator

@nkysg nkysg commented Apr 2, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

fix code style and remove dup code

Other information

@nkysg nkysg requested a review from jolestar April 6, 2022 01:20
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #3311 (89197c8) into master (b77d036) will decrease coverage by 0.33%.
The diff coverage is 15.60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3311      +/-   ##
==========================================
- Coverage   32.01%   31.68%   -0.32%     
==========================================
  Files         500      500              
  Lines       46484    46760     +276     
  Branches    21037    21257     +220     
==========================================
- Hits        14875    14811      -64     
- Misses      17888    17947      +59     
- Partials    13721    14002     +281     
Flag Coverage Δ
unittests 31.68% <15.60%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
chain/api/src/message.rs 0.00% <0.00%> (ø)
chain/api/src/service.rs 10.17% <0.00%> (+0.42%) ⬆️
chain/service/src/chain_service.rs 22.56% <0.00%> (-0.52%) ⬇️
chain/src/chain.rs 34.19% <0.00%> (+0.43%) ⬆️
chain/src/verifier/mod.rs 39.84% <ø> (+0.17%) ⬆️
...e-jellyfish-merkle/src/node_type/node_type_test.rs 37.98% <ø> (ø)
executor/src/account.rs 10.35% <0.00%> (-3.94%) ⬇️
network-rpc/src/rpc.rs 19.32% <0.00%> (+1.37%) ⬆️
node/src/node.rs 10.49% <0.00%> (-1.31%) ⬇️
rpc/client/src/chain_watcher.rs 10.59% <0.00%> (ø)
... and 85 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03b8e9...89197c8. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Benchmark for a6b451c

Click to view benchmark
Test Base PR %
accumulator_append 595.7±14.93µs 595.3±13.36µs -0.07%
block_apply/block_apply_10 268.9±2.98ms 267.0±0.99ms -0.71%
block_apply/block_apply_1000 27.5±0.09s 27.6±0.03s +0.36%
get_with_proof/db_store 36.2±0.40µs 35.9±0.68µs -0.83%
get_with_proof/mem_store 31.2±0.27µs 30.8±0.33µs -1.28%
put_and_commit/db_store/1 96.4±5.11µs 96.1±5.62µs -0.31%
put_and_commit/db_store/10 869.2±42.89µs 861.8±40.11µs -0.85%
put_and_commit/db_store/100 7.4±0.31ms 7.4±0.29ms 0.00%
put_and_commit/db_store/5 447.0±25.18µs 438.0±23.37µs -2.01%
put_and_commit/db_store/50 3.8±0.16ms 3.8±0.15ms 0.00%
put_and_commit/mem_store/1 62.1±5.70µs 61.6±5.64µs -0.81%
put_and_commit/mem_store/10 579.0±48.60µs 575.1±47.09µs -0.67%
put_and_commit/mem_store/100 5.7±0.82ms 5.6±0.33ms -1.75%
put_and_commit/mem_store/5 292.9±25.59µs 288.9±24.64µs -1.37%
put_and_commit/mem_store/50 2.9±0.19ms 2.8±0.19ms -3.45%
query_block/query_block_in(10)_times(100) 3.9±0.22ms 3.9±0.13ms 0.00%
query_block/query_block_in(10)_times(1000) 38.3±1.15ms 38.3±0.68ms 0.00%
query_block/query_block_in(10)_times(10000) 382.1±6.93ms 382.9±4.26ms +0.21%
query_block/query_block_in(1000)_times(100) 954.9±7.28µs 954.2±10.79µs -0.07%
query_block/query_block_in(1000)_times(1000) 9.5±0.05ms 9.4±0.08ms -1.05%
query_block/query_block_in(1000)_times(10000) 95.0±0.58ms 95.0±1.11ms 0.00%
storage_transaction 1069.5±293.21µs 1063.7±288.80µs -0.54%
vm/transaction_execution/1 316.7±0.88ms 325.2±2.81ms +2.68%
vm/transaction_execution/10 99.7±1.21ms 100.8±0.73ms +1.10%
vm/transaction_execution/20 91.6±1.25ms 92.7±0.52ms +1.20%
vm/transaction_execution/5 121.7±0.88ms 123.7±0.40ms +1.64%
vm/transaction_execution/50 104.8±5.95ms 104.5±0.50ms -0.29%

@jolestar jolestar merged commit b96c8ee into master Apr 6, 2022
@jolestar jolestar deleted the clippy_vec_init_and_push branch April 6, 2022 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants