Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[move] Update move for fix StructTag json compatibility bug #3272

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

jolestar
Copy link
Member

@jolestar jolestar commented Mar 8, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

the Move changes at:

starcoinorg/move#2

Compatibility notes:

  1. New CLI client can connect to old node RPC (json deserialize compatibility)
  2. But Old CLI client can not connect to the new RPC.

The following RPC APIs are mainly affected:

  1. account.sign_txn
  2. txpool.submit_transaction

The scripts/import_net_block.sh also affected, old data can be imported by new starcoin binary, but when exporting new json data, it can not be imported by old starcoin binary.

Issue Number: N/A

What is the new behavior?

Other information

@jolestar jolestar requested review from sanlee42 and nkysg March 8, 2022 09:47
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #3272 (7d9086f) into master (6dac036) will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3272      +/-   ##
==========================================
- Coverage   32.33%   32.06%   -0.27%     
==========================================
  Files         499      499              
  Lines       46194    46197       +3     
  Branches    20897    20910      +13     
==========================================
- Hits        14931    14807     -124     
+ Misses      17755    17717      -38     
- Partials    13508    13673     +165     
Flag Coverage Δ
unittests 32.06% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
executor/src/block_executor.rs 27.66% <0.00%> (-12.76%) ⬇️
vm/types/src/on_chain_config/mod.rs 43.84% <0.00%> (-12.32%) ⬇️
network-p2p/src/transport.rs 15.10% <0.00%> (-11.32%) ⬇️
chain/open-block/src/lib.rs 31.58% <0.00%> (-9.86%) ⬇️
chain/src/verifier/mod.rs 39.67% <0.00%> (-9.09%) ⬇️
types/src/account_state.rs 63.34% <0.00%> (-6.66%) ⬇️
commons/accumulator/src/tree.rs 56.59% <0.00%> (-6.34%) ⬇️
state/state-store-api/src/lib.rs 43.75% <0.00%> (-6.25%) ⬇️
storage/src/transaction_info/mod.rs 46.52% <0.00%> (-4.65%) ⬇️
sync/src/block_connector/test_write_block_chain.rs 32.56% <0.00%> (-4.65%) ⬇️
... and 65 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6dac036...7d9086f. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Benchmark for 1573a58

Click to view benchmark
Test Base PR %
accumulator_append 593.1±10.38µs 590.3±11.30µs -0.47%
block_apply/block_apply_10 267.8±1.19ms 268.5±1.62ms +0.26%
block_apply/block_apply_1000 27.4±0.03s 27.5±0.04s +0.36%
get_with_proof/db_store 35.9±0.41µs 36.0±0.51µs +0.28%
get_with_proof/mem_store 31.2±0.36µs 31.0±0.27µs -0.64%
put_and_commit/db_store/1 94.5±4.94µs 94.6±4.86µs +0.11%
put_and_commit/db_store/10 852.0±37.83µs 852.5±43.22µs +0.06%
put_and_commit/db_store/100 7.4±0.30ms 7.3±0.30ms -1.35%
put_and_commit/db_store/5 438.5±20.89µs 431.9±22.55µs -1.51%
put_and_commit/db_store/50 3.8±0.18ms 3.8±0.17ms 0.00%
put_and_commit/mem_store/1 61.5±5.45µs 60.9±5.34µs -0.98%
put_and_commit/mem_store/10 577.6±47.15µs 577.6±46.34µs 0.00%
put_and_commit/mem_store/100 5.7±0.80ms 5.6±0.81ms -1.75%
put_and_commit/mem_store/5 292.8±24.03µs 291.8±24.01µs -0.34%
put_and_commit/mem_store/50 2.8±0.18ms 2.8±0.18ms 0.00%
query_block/query_block_in(10)_times(100) 3.9±0.09ms 3.9±0.08ms 0.00%
query_block/query_block_in(10)_times(1000) 38.5±0.50ms 38.9±1.54ms +1.04%
query_block/query_block_in(10)_times(10000) 388.7±6.68ms 390.5±7.50ms +0.46%
query_block/query_block_in(1000)_times(100) 944.2±10.67µs 948.5±6.32µs +0.46%
query_block/query_block_in(1000)_times(1000) 9.4±0.07ms 9.5±0.09ms +1.06%
query_block/query_block_in(1000)_times(10000) 94.4±0.78ms 96.0±2.91ms +1.69%
storage_transaction 1052.9±297.71µs 1077.4±363.94µs +2.33%
vm/transaction_execution/1 315.2±1.18ms 315.4±0.83ms +0.06%
vm/transaction_execution/10 99.6±2.50ms 98.5±0.22ms -1.10%
vm/transaction_execution/20 90.7±0.38ms 90.9±0.32ms +0.22%
vm/transaction_execution/5 122.1±4.07ms 121.3±0.85ms -0.66%
vm/transaction_execution/50 102.7±0.69ms 102.8±1.21ms +0.10%

@jolestar jolestar merged commit 4366b05 into master Mar 9, 2022
@jolestar jolestar deleted the type_tag_case_insensitive branch March 9, 2022 01:15
@jolestar jolestar linked an issue Mar 9, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

submit txn failed through websocket
2 participants