-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expectations fix #35
Expectations fix #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(skimming)
README.md
Outdated
@@ -91,3 +91,63 @@ or for a dry run to preview dropped models: | |||
```bash | |||
dbt run-operation trino__drop_old_relations --args "{dry_run: true}" | |||
``` | |||
|
|||
## Contributing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can move this section to a new file DEVELOPMENT.md
Please rebase since there are some conflicts. |
Tests are not executed on the CI, please add them to |
something is failing in the CI https://github.com/starburstdata/dbt-trino-utils/actions/runs/6509366529/job/17732540173?pr=35#step:4:2696 |
Do you think This is because I am importing the source project and also I copied the tests from the source project into the integration tests folder? |
Yes it might be this, it's some conflict between two |
a136c3c
to
2ea854f
Compare
@wjhrdy Please pause your work on this PR. We are considering another approach, which involves adding Trino support directly to the |
That works! Just for your reference, it was recommended by the https://github.com/calogica/dbt-expectations/issues/243#issuecomment-1441189188 |
Trino is now supported directly in dbt_expectations. |
This fixes #21 and one other bug when using the
dbt_expectations
package.It adds the
dbt_expectations
test-suite which all runs without db errors but doesn't all pass weirdly.The two macros that have overrides are.
Also added Readme section to help future contributors.