Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: netbsd - uname requires arg in 3.8.0 #374

Merged
merged 1 commit into from
Mar 16, 2024
Merged

fix: netbsd - uname requires arg in 3.8.0 #374

merged 1 commit into from
Mar 16, 2024

Conversation

YOU54F
Copy link
Contributor

@YOU54F YOU54F commented Mar 16, 2024

Building for x86_64-unknown-netbsd results in an error after upgrading os_info to 3.8.0

error[E0061]: this function takes 1 argument but 0 arguments were supplied
  --> /home/runner/.cargo/git/checkouts/os_info-2e057b05809a1ca6/83fc567/os_info/src/netbsd/mod.rs:10:19
   |
10 |     let version = uname()
   |                   ^^^^^-- an argument of type `&str` is missing
   |
note: function defined here
  --> /home/runner/.cargo/git/checkouts/os_info-2e057b05809a1ca6/83fc567/os_info/src/uname.rs:5:8
   |
5  | pub fn uname(arg: &str) -> Option<String> {
   |        ^^^^^ ---------
help: provide the argument
   |
10 |     let version = uname(/* &str */)
   |                        ~~~~~~~~~~~~

@YOU54F YOU54F requested a review from stanislav-tkach as a code owner March 16, 2024 15:22
Copy link
Owner

@stanislav-tkach stanislav-tkach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request!

@stanislav-tkach stanislav-tkach merged commit 452c3bc into stanislav-tkach:master Mar 16, 2024
20 checks passed
@zanchey
Copy link
Contributor

zanchey commented Dec 31, 2024

I think this is wrong; NetBSD's uname doesn't have a -o option.

@YOU54F
Copy link
Contributor Author

YOU54F commented Dec 31, 2024

doh. you are correct

https://man.netbsd.org/uname.1

think -v should work

you can try in a patch and use that in your build to check it works

@0-wiz-0 0-wiz-0 mentioned this pull request Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants