Recognise Arch Linux when using file release #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislav-tkach
approved these changes
Jul 23, 2020
|
What are your thoughts on having an alternative matcher for the version? I'm afraid we may need N of them (for other distros with other version names) and not sure if vectors work in constants. Should I make an issue to discuss this? |
|
@Lonami Yes, I think it would be better to have a separate issue to discuss this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It (unfortunately) uses the same path as Oracle Linux:
https://github.com/DarkEld3r/os_info/blob/f9088845198fa9951f6d97a7bb35d035046f707b/os_info/src/linux/file_release.rs#L72-L76
However just detecting the type name helps avoid it being mis-assigned (I guess ideally we would do this for all other types but I only have access to an Arch machine at the moment).
I would also make it detect
BUILD_ID(instead ofVERSION_ID), maybe with some form of "alternative matcher", but there are other issues with that (#207).