Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip completed display JSON #1620

Merged
merged 1 commit into from
May 31, 2023
Merged

Conversation

yifanmai
Copy link
Collaborator

This significantly speeds up helm-summarize for the use case where we run helm-summarize on a run suite with some existing runs, add some runs using helm-run, and then run helm-summarize over the suite again. In this case, we skip re-computing the display JSON for the existing runs.

@yifanmai yifanmai requested review from percyliang and teetone May 27, 2023 03:01
Copy link
Contributor

@percyliang percyliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but also hard for me to reason globally about the flow (when this flag should be used). Is the whole process (especially for making incremental changes) documented somewhere?

@yifanmai
Copy link
Collaborator Author

There are still likely changes to the workflow in the near future, with helm-summarize changes, so maybe we add docs after that.

@yifanmai yifanmai merged commit 17e63ec into main May 31, 2023
@yifanmai yifanmai deleted the yifanmai/fix-summarize-skip-completed branch May 31, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants