Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect diagnosticProvider value of LSP #579

Merged

Conversation

koic
Copy link
Contributor

@koic koic commented Aug 30, 2023

Summary

This PR fixes incorrect diagnosticProvider value of LSP.

diagnosticProvider cannot accept true as below. This PR replaces the originally acceptable value.

/**
 * The server has support for pull model diagnostics.
 *
 * @since 3.17.0
 */
diagnosticProvider?: DiagnosticOptions | DiagnosticRegistrationOptions;

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialize

Additional Information

This issue was found in rubocop/rubocop#12154.

## Summary

This PR fixes incorrect `diagnosticProvider` value of LSP.

`diagnosticProvider` cannot accept `true` as below. This PR replaces the originally acceptable value.

```typescript
/**
 * The server has support for pull model diagnostics.
 *
 * @SInCE 3.17.0
 */
diagnosticProvider?: DiagnosticOptions | DiagnosticRegistrationOptions;
```

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#initialize

## Additional Information

This issue was found in rubocop/rubocop#12154.
@searls
Copy link
Contributor

searls commented Aug 30, 2023

Thanks for looking out!

@searls searls merged commit 3d754f8 into standardrb:main Aug 30, 2023
@koic koic deleted the fix_incorrect_diagnostic_provider_value_of_lsp branch August 30, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants