Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable Rails/HasManyOrHasOneDependent #53

Merged

Conversation

Cohen-Carlisle
Copy link
Contributor

they say fortune favors the bold so... here's a PR!

See issue (linked below) for my rationale.

closes #50

@searls
Copy link
Contributor

searls commented Jul 20, 2024

I agree, there are valid cases where you don't want to do this. I might keep it in if Rails offered a better option than nil for specifying "don't do anything" (like :ignore), but even then I'm 👎 on any rule that'd make some people just add more ceremony for the sake of making a linter happy

@searls searls merged commit 1a593d4 into standardrb:main Jul 20, 2024
4 checks passed
@Cohen-Carlisle Cohen-Carlisle deleted the disable-has-many-or-has-one-dependent branch July 30, 2024 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Rails/HasManyOrHasOneDependent ?
2 participants