Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new "Change Editor" option to note context menu #823

Merged
merged 32 commits into from
Jan 28, 2022
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
6de0606
feat: add editor icon
amanharwara Jan 22, 2022
9432d41
refactor: remove 'any' type and format
amanharwara Jan 22, 2022
d09b5e0
refactor: move NotesOptions and add ChangeEditorOption
amanharwara Jan 22, 2022
723012e
refactor: fix type for using regular RefObject<T>
amanharwara Jan 22, 2022
73852b4
feat: add hide-if-last-child util class
amanharwara Jan 22, 2022
01ddb15
feat: add Change Editor option
amanharwara Jan 22, 2022
02a93ce
feat: make radio btn gray if not checked
amanharwara Jan 23, 2022
502fb6c
fix: accordion menu header and item sizing/spacing
amanharwara Jan 23, 2022
c578cfd
feat: add Escape key to KeyboardKey enum
amanharwara Jan 23, 2022
cc6b0e7
refactor: Remove Editor Menu
amanharwara Jan 23, 2022
8e19d34
feat: add editor select functionality
amanharwara Jan 23, 2022
dc52ed5
refactor: move plain editor name to constant
amanharwara Jan 23, 2022
340f712
feat: add premium editors with modal if no subscription
amanharwara Jan 23, 2022
73911f7
feat: show alert when switching to non-interchangeable editor
amanharwara Jan 24, 2022
6e7941e
fix: change editor menu going out of bounds
amanharwara Jan 24, 2022
8a1c2a0
feat: increase group header & editor item size
amanharwara Jan 24, 2022
52af361
fix: change editor menu close on blur
amanharwara Jan 24, 2022
f1bbbf2
refactor: Use KeyboardKey enum & remove else statement
amanharwara Jan 24, 2022
22b6846
feat: add keyboard navigation to change editor menu
amanharwara Jan 24, 2022
2e22c2a
fix: editor menu separators
amanharwara Jan 24, 2022
15e6293
feat: improve change editor menu sizing & spacing
amanharwara Jan 25, 2022
6ca9117
feat: show alert only if editor is not interchangeable
amanharwara Jan 26, 2022
7e6685f
feat: don't show alert when switching to/from plain editor
amanharwara Jan 26, 2022
267a360
chore: bump snjs version
amanharwara Jan 26, 2022
6ef47db
Merge branch 'develop' into feat/new-change-editor-flow
amanharwara Jan 26, 2022
c67f9f2
feat: temporarily remove change editor alert
amanharwara Jan 28, 2022
3f737e1
Merge branch 'develop' into feat/new-change-editor-flow
amanharwara Jan 28, 2022
d436e83
feat: dynamically get footer height
amanharwara Jan 28, 2022
1fed8c1
Merge branch 'feat/new-change-editor-flow' of github.com:standardnote…
amanharwara Jan 28, 2022
368b7ad
refactor: move magic number to const
amanharwara Jan 28, 2022
54b3413
refactor: move constants to constants file
amanharwara Jan 28, 2022
946ecc3
feat: use const instead of magic number
amanharwara Jan 28, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: fix type for using regular RefObject<T>
  • Loading branch information
amanharwara committed Jan 22, 2022

Verified

This commit was signed with the committer’s verified signature. The key has expired.
amanharwara Aman Harwara
commit 723012ef3b0483768586f8c6bd3f0ede417174e8
2 changes: 1 addition & 1 deletion app/assets/javascripts/components/utils.ts
Original file line number Diff line number Diff line change
@@ -8,7 +8,7 @@ import { StateUpdater, useCallback, useState, useEffect } from 'preact/hooks';
* monitored.
*/
export function useCloseOnBlur(
container: { current?: HTMLDivElement },
container: { current?: HTMLDivElement | null },
setOpen: (open: boolean) => void
): [
(event: { relatedTarget: EventTarget | null }) => void,