feat: migrate search to snjs #526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a consistent search experience on all devices and operating systems
…/cubes nothing (merge) :
arielsvg
reviewed
Mar 2, 2021
| @@ -6,6 +6,7 @@ module.exports = (env, argv) => { | |||
| const port = argv.port || 3001; | |||
| return merge(config(env, argv), { | |||
| mode: 'development', | |||
| devtool: 'inline-source-map', | |||
There was a problem hiding this comment.
Wait we didn't have a lighter special sourcemap option set up before? 😳
|
Note that we won't be able to merge this in until the associated SNJS PR gets merged and released, and the web dependency gets updated :) standardnotes/snjs#230 |
|
Superseded by #530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating search to SNJS allows providing a consistent experience across all devices and platforms.