Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notes display criteria #530

Merged
merged 4 commits into from
Mar 4, 2021
Merged

feat: notes display criteria #530

merged 4 commits into from
Mar 4, 2021

Conversation

moughxyz
Copy link
Member

@moughxyz moughxyz commented Mar 4, 2021

Incorporates SNJS's new NotesSearchCriteria feature. This PR doesn't include the updated SNJS version, since that's not yet published. So if you'd like to test it you'll need to yarn link locally.

@antsgar a similar change will be necessary in mobile.

@moughxyz moughxyz requested a review from arielsvg March 4, 2021 00:12
Copy link
Contributor

@arielsvg arielsvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of this looks good to me but should not be merged before the related SNJS PR has been merged (which will make the tsc check pass) 👍

@moughxyz moughxyz merged commit e0ab938 into develop Mar 4, 2021
@moughxyz moughxyz deleted the search-refactor branch March 4, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants