Tagged template string considered an expression, not a function call

[yoshuawuyts]

Intro

Template strings are a way to interpolate variables with strings. It's nice, and often more readable than traditional string concatenation

Tagged template strings take this behavior a bit further, and allow functions to be called as if they were strings - but instead the functions receive multiple strings, and a trailing array of positional arguments that the have been used for interpolation. This allows operating on the string and adding all sorts of interesting behavior.

Example

var css = require('sheetify')

// this is a static expression
`
  .js-yellow { color: #f7df1e }
  .bg-js-yellow { background-color: #f7df1e }
`

// this is a function call, which in this case has side effects
css`
  .js-yellow { color: #f7df1e }
  .bg-js-yellow { background-color: #f7df1e }
`

Bug

It appears that standard@9 has introduced a regression where tagged template strings are now considered static expressions - even though they're functions. I think we should probably look into this.

❯ standard
standard: Use JavaScript Standard Style (http://standardjs.com)
  /Users/anon/src/yoshuawuyts/berlinjs/index.js:14:1: Expected an assignm
ent or function call and instead saw an expression.

Thanks!

[feross]

Thanks for the issue, @yoshuawuyts. This sounds like a bug in ESLint's no-unused-expressions rule. I'll open an issue with them.

[yoshuawuyts]

Thank you :D

…

On Fri, Mar 17, 2017, 01:28 Feross Aboukhadijeh ***@***.***> wrote: Thanks for the issue, @yoshuawuyts <https://github.com/yoshuawuyts>. This sounds like a bug in ESLint's no-unused-expressions <http://eslint.org/docs/rules/no-unused-expressions> rule. I'll open an issue with them. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#822 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACWleuW4Kz7xzeDtLmEPlVyQ_a9AFqneks5rmdOcgaJpZM4Mf-lN> .

[feross]

Issue filed here: eslint/eslint#8268

[feross]

They actually already have a PR out that adds an option to ignore tagged template literals: eslint/eslint#8253 When that makes it into a release, I'll add the option and publish a new version on the v9 and v10 lines.

[vitorbal]

@feross FYI, today's release will most likely contain this fix!

[feross]

@vitorbal Excellent! Just saw that. I'll do a standard release as soon as the ESLint release is out. 👍

[feross]

Fix published as 9.0.2.

(Also, for users of the v10 beta, published as 10.0.0-beta.2.)