Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent users getting stuck with 401s due to too many Auth Tokens #547

Closed
4 tasks
gsgalloway opened this issue Mar 20, 2023 · 1 comment
Closed
4 tasks
Labels

Comments

@gsgalloway
Copy link
Contributor

There's some degenerate behavior where once a user has too many API tokens active at once, they start hitting 401 errors from the Warpcast API.

Here's a TG thread showcasing the issue: https://t.me/farcasterdevchat/3441

Here is a script people have been using to wipe all outstanding tokens: https://github.com/davidfurlong/farcaster-auth-tokens/blob/main/revoke-all.ts

We should:

  • Reproduce the issue in a test
  • Understand the user story that results in this situation. I think it's user's just re-instantiating the MerkleAPIClient class over and over instead of reusing it. Which is a valid thing to want to do, and would surprise a user when it eventually leads to 401s.
  • Add in the function to help users wipe all existing auth tokens
  • Add code or documentation to prevent users from running into this problem
github-actions bot pushed a commit that referenced this issue Mar 21, 2023
# [5.6.0](v5.5.4...v5.6.0) (2023-03-21)

### Features

* prevent users getting stuck with 401s due to too many Auth Tokens ([a8d6941](a8d6941)), closes [#547](#547)
* wrap the Healtcheck Warpcast API endpoint ([b29d7cf](b29d7cf)), closes [#541](#541)
* wrap Warpcast API methods for signer requests ([00f193d](00f193d)), closes [#539](#539)
@github-actions
Copy link

🎉 This issue has been resolved in version 5.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant