-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save Bounty State When Browsing #950
Save Bounty State When Browsing #950
Conversation
…ce on modal close
@humansinstitute Could you please review the PR? Issue: On Workspace Bounties, opening a bounty modal changes the URL to /bounty/:bountyId. Closing the modal redirects back to /workspace/bounties/:bountyId, causing the component to reload, resetting the bounties to the initial 25 items. |
@humansinstitute I have spent many hours on this and try different methods but not succeed yet because of path difference |
No offence @MahtabBukhari your loom doesn't show the issue being fixed. You don't click on any card in workspace bounties throughout the video to demonstrate the fix as working. You should probably make a new video demonstrating you click on one closing the card and the state being preserved |
@jordan-ae Have you read this one? |
Oh sorry didn't read see that my bad. You couldn't find a fix because this isn't a bug (as I expressed in a PR I've now closed) it's a design flaw mostly stemming from the fact that this component wasn't built with reuse ability in mind. @MahtabBukhari @humansinstitute I think we should consider it a refactor of the component rather than a bug because there's no bug it's just the intended behaviour of the component. What do you guys think? |
@jordan-ae yeah you are right |
@humansinstitute you can merge this one PR it has resolved the issue of when we click on load more button then the new bounties loaded and previously disappeared |
i think the approach outlined here is probably correct with refactoring the component. |
Link to: #959 |
Describe your changes
Issue ticket number and link: https://community.sphinx.chat/bounty/3394
Evidence: https://www.loom.com/share/b6407f23279840f79d7f2904ae74ea0e?sid=98f18fd2-dfff-4880-b358-5271119e9ad1
Type of change
Please delete options that are not relevant.
Checklist before requesting a review