Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for security group filter type #15

Merged
merged 7 commits into from
Jul 31, 2020
Merged

add support for security group filter type #15

merged 7 commits into from
Jul 31, 2020

Conversation

fahad-rauf
Copy link
Contributor

No description provided.

@fahad-rauf fahad-rauf requested a review from hamza3202 July 17, 2020 15:10
@stakater-user
Copy link
Contributor

@fahad-rauf Image is available for testing. docker pull stakater/whitelister:SNAPSHOT-PR-15-1

@stakater-user
Copy link
Contributor

@fahad-rauf Image is available for testing. docker pull stakater/whitelister:SNAPSHOT-PR-15-2

@stakater-user
Copy link
Contributor

@fahad-rauf Image is available for testing. docker pull stakater/whitelister:SNAPSHOT-PR-15-3

hamza3202
hamza3202 suggested changes Jul 20, 2020
View reviewed changes
internal/pkg/config/config_test.go Show resolved Hide resolved
internal/pkg/config/filterType.go Outdated Show resolved Hide resolved
internal/pkg/config/filterType.go Outdated Show resolved Hide resolved
internal/pkg/config/filterType.go Outdated Show resolved Hide resolved
internal/pkg/providers/aws/securityGroupFetcher.go Outdated Show resolved Hide resolved
internal/pkg/config/filterType.go Outdated Show resolved Hide resolved
internal/pkg/providers/aws/ec2IpPermissions.go Outdated Show resolved Hide resolved
internal/pkg/providers/aws/securityGroupFetcher.go Outdated Show resolved Hide resolved
internal/pkg/providers/aws/securityGroupUpdator.go Outdated Show resolved Hide resolved
internal/pkg/providers/provider.go Outdated Show resolved Hide resolved
@stakater-user
Copy link
Contributor

@fahad-rauf Image is available for testing. docker pull stakater/whitelister:SNAPSHOT-PR-15-4

hamza3202
hamza3202 suggested changes Jul 24, 2020
View reviewed changes
internal/pkg/providers/aws/aws.go Outdated Show resolved Hide resolved
internal/pkg/providers/aws/security_group_updator.go Outdated Show resolved Hide resolved
@stakater-user
Copy link
Contributor

@fahad-rauf Image is available for testing. docker pull stakater/whitelister:SNAPSHOT-PR-15-5

hamza3202
hamza3202 suggested changes Jul 27, 2020
View reviewed changes
Copy link
Contributor

@hamza3202 hamza3202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good now.
Only need to add and update existing documentation and mention different filter types.

@stakater-user
Copy link
Contributor

@fahad-rauf Image is available for testing. docker pull stakater/whitelister:SNAPSHOT-PR-15-6

@rasheedamir rasheedamir self-requested a review July 31, 2020 06:55
rasheedamir
rasheedamir previously approved these changes Jul 31, 2020
View reviewed changes
hamza3202
hamza3202 suggested changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@hamza3202 hamza3202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider Approved once this requested change is done

docs/config.md Show resolved Hide resolved
@stakater-user
Copy link
Contributor

@fahad-rauf Image is available for testing. docker pull stakater/whitelister:SNAPSHOT-PR-15-7

@fahad-rauf fahad-rauf merged commit 9c806ba into master Jul 31, 2020
@rasheedamir rasheedamir deleted the sec-group-support branch July 31, 2020 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamza3202 hamza3202 hamza3202 approved these changes

@rasheedamir rasheedamir rasheedamir left review comments

@waseem-h waseem-h Awaiting requested review from waseem-h

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fahad-rauf @stakater-user @rasheedamir @hamza3202 @waseem-h