Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix for POD_NAME and POD_NAMESPACE envs when enableHA is true #723

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

robgordon89
Copy link
Contributor

@robgordon89 robgordon89 commented Aug 7, 2024

fix for POD_NAME and POD_NAMESPACE envs when enableHA is true

Also added a test case to cover it 👍

Fixes:

Error: POD_NAME not set, cannot run in HA mode without POD_NAME set

Likely introduced here #699

@stefanandres
Copy link

stefanandres commented Aug 7, 2024

If you are on it, please also fix the default values for the new variables. They are mixed up:

        - name: GOMAXPROCS
          valueFrom:
            resourceFieldRef:
              resource: limits.memory
        - name: GOMEMLIMIT
          valueFrom:
            resourceFieldRef:
              resource: limits.cpu

This should be the other way around,
GOMAXPROCS = limits.cpu
GOMEMLIMIT = limits.memory

With this current default, all pods are crashing at startup with OOMKill.

@bnallapeta
Copy link

will look at the image generation issue with the pipeline later. Merging this PR for now.

@bnallapeta bnallapeta merged commit 04a9874 into stakater:master Aug 7, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants