-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature reload-on-delete implemented, test cases enhanced #695
Conversation
@deschmih Images are available for testing. |
@MuneebAijaz reviewers are welcome ;-) Test cases are enhanced. |
@MuneebAijaz - Are you the right person to review this pull request in a timely manner ? |
@deschmih you could say so, but a bit busy for last few weeks. I will try to review it today, max tomorrow. |
I believe in you brotha |
hi @deschmih PR looks fine. can you resolve conflicts and pls separate out docs changes in another PR? There's is an ongoing issue about docs and code workflows running together causing issues. |
@deschmih Images are available for testing. |
@deschmih Images are available for testing. |
@MuneebAijaz All conflicts resolved. Removed changes to readme.md (doc). After this PR is approved, a separate PR will be created to modify readme.md. |
@MuneebAijaz now it should be fixed |
@deschmih Images are available for testing. |
thank you @deschmih. You are the best ❤️ |
Great job! @deschmih thanks for you input here |
This PR contains the feature "reload-on-delete" as enhancement refering to issue #622.
For beeing backwards compatible an additional flag
reload-on-delete
at commandline is implemented for using this feature. This corresponding flagreloadOnDelete
is also now part in the values.yaml of the helm chart. Testcases are enhaced.