Fix docker setup #298
Open
Fix docker setup #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
bin/bundle-binstub
Outdated
| @@ -27,7 +27,7 @@ m = Module.new do | |||
| bundler_version = nil | |||
| update_index = nil | |||
| ARGV.each_with_index do |a, i| | |||
| if update_index && update_index.succ == i && a =~ Gem::Version::ANCHORED_VERSION_PATTERN | |||
| if update_index && update_index.succ == i && a.match?(Gem::Version::ANCHORED_VERSION_PATTERN) | |||
There was a problem hiding this comment.
[Rubocop] reported by reviewdog 🐶
[Correctable] Style/IfUnlessModifier: Favor modifier if usage when having a single-line body. Another good alternative is the usage of control flow &&/||.
bin/bundle-binstub
Outdated
| @@ -47,7 +47,7 @@ | |||
| def lockfile | |||
| lockfile = | |||
| case File.basename(gemfile) | |||
| when "gems.rb" then gemfile.sub(/\.rb$/, gemfile) | |||
| when "gems.rb" then gemfile.sub(/\.rb$/, ".locked") | |||
There was a problem hiding this comment.
[Rubocop] reported by reviewdog 🐶
[Correctable] Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
bin/bundle-binstub
Outdated
| @@ -47,7 +47,7 @@ | |||
| def lockfile | |||
| lockfile = | |||
| case File.basename(gemfile) | |||
| when "gems.rb" then gemfile.sub(/\.rb$/, gemfile) | |||
| when "gems.rb" then gemfile.sub(/\.rb$/, ".locked") | |||
There was a problem hiding this comment.
[Rubocop] reported by reviewdog 🐶
[Correctable] Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Kagemaru
force-pushed
the
bug/fix_docker_setup
branch
from
e5fc28e
to
1b9cacd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.