React Native mono-repo structure #463
Conversation
| @@ -0,0 +1 @@ | |||
| # core | |||
There was a problem hiding this comment.
Doesn't need to be fancy, but let's at least put a few lines here :)
| "ferrostar-rn-core": ["./src/index"] | ||
| } | ||
| }, | ||
| "exclude": ["lib"] |
There was a problem hiding this comment.
Is this auto-generated? I don't see anything at that path in the PR.
| "extends": "../tsconfig.base", | ||
| "compilerOptions": { | ||
| "paths": { | ||
| "ferrostar-rn-core": ["./src/index"] |
There was a problem hiding this comment.
Ahh nice; I guess that lets us work a bit more conveniently in a multi-package "workspace!"
| "resolutions": { | ||
| "@types/react": "^18.2.44" | ||
| }, |
There was a problem hiding this comment.
Hmm... I guess there's some dependency web that means we have to specify a resolution here manually?
| @@ -0,0 +1,78 @@ | |||
| { | |||
| "name": "ferrostar-rn-core", | |||
| "version": "0.27.0", | |||
There was a problem hiding this comment.
Could you add support for all the React Native files to update-release-version.sh?
| "ferrostar-rn-maplibreui": ["./src/index"] | ||
| } | ||
| }, | ||
| "exclude": ["lib"] |
There was a problem hiding this comment.
Should this stay at the "root" of the react native tree? Moving it under UniFFI seems oddly specific.
| "ferrostar-rn-uniffi": ["./src/index"] | ||
| } | ||
| }, | ||
| "exclude": ["lib"] |
I've split the react native project into 4 projects uniffi, core, maplibreui and example.
I think I finally got the typescript definitions behaving enough for local development by pointing it at the
./src/index.tsxfile, but am unsure whether the uniffi project an be published in it's current state with it's typescript definitions not 100% building. I've created an issue in the uniffi-bindgen-react-native repo to see if they have an ideas jhugman/uniffi-bindgen-react-native#220I would like some suggestions on names for these separate projects as I don't like the ones I've currently chosen.
Maybe we should name them something around these lines, but these seem quite long. Let me know what you think @ianthetechie
Still need to make sure that this thing is build-able in the example project and clean up some of the build stuff between all the projects as I know some of it can be merged to together. I've already started this by making the
tsconfig.jsonfiles all reference a root config file.