Add c# .net core support #40
Conversation
…s compiling and running.
|
Awesome thanks. I'd like to add some user documentation around how to create .NET Core services as a minimum. Since I've realised that requiring the service to be a full console app project may be is unnecessary and somewhat un-FaaS like. This could be improved to only require a *.cs containing a class, templating the rest out. However, I need to think through how a user would add dependencies would work without direct access to the csproj file. TODO
The first two are probably sensible to tackle. Without the last one, it may need to go out with a beta label. Let me know your thoughts. |
|
That all makes sense. I've been working on a few changes to some internals in another branch, but I don't think they will affect anything I've seen in this PR. I don't do much work with dotnet, but I'd like to see this added. Not sure what qualifies as a dotnet console app, but I'd like to see this supported for http server applications. Please make sure to try and encapsulate the dotnet logic as much as possible. I see we've added Please let me know if have any questions. I'm okay with Beta support to start. Thank you again for your contributions. |
|
Agreed. The change I'm suggesting should mean that this property on the
service object is not required. I haven't thought through this change in
detail yet though. I'll try and make some time next week to do that.
…On 30 Aug 2017 9:52 pm, "Marak" ***@***.***> wrote:
That all makes sense. I've been working on a few changes to some internals
in another branch, but I don't think they will affect anything I've seen in
this PR.
I don't do much work with dotnet, but I'd like to see this added. Not sure
what qualifies as a dotnet console app, but I'd like to see this supported
for http server applications.
Please make sure to try and encapsulate the dotnet logic as much as
possible. I see we've added originalCodeFilePath. Not sure if that's
something dotnet specific or that we should add to the API.
Please let me know if have any questions. I'm okay with Beta support to
start. Thank you again for your contributions.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADKQ28y8QXfEGTYlwXF1s9DyD0NCarhks5sdcuGgaJpZM4PH364>
.
|
|
Hi, I'm sorry I did not get to this as promised. Obviously wasn't able to make time as I was away. I'll have to ramp up on it again, hopefully far less time consuming for me than last time. |
@janaka
This looks awesome! I've opened a PR to begin to review the changes for .net support.
I've been planning on doing a new release soon, so let me know if there was anything else you wanted to add or change.