Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reorg_attempts_activity_timeout_ms config option and tenure_activity table to track miner activity #5755

Merged
merged 16 commits into from
Feb 5, 2025
Merged

Add reorg_attempts_activity_timeout_ms config option and tenure_activity table to track miner activity #5755

merged 16 commits into from
Feb 5, 2025

Conversation

jferrant
Copy link
Collaborator

Closes #5749

@jferrant jferrant requested review from a team as code owners January 27, 2025 22:41
@jferrant jferrant marked this pull request as draft January 28, 2025 16:50
@jferrant jferrant marked this pull request as ready for review January 28, 2025 16:51
obycode
obycode reviewed Jan 28, 2025
View reviewed changes
@jferrant jferrant requested a review from obycode January 29, 2025 02:10
@aldur aldur added this to the 3.1.0.0.5 milestone Jan 29, 2025
@aldur aldur requested a review from rdeioris January 29, 2025 16:13
@jferrant jferrant marked this pull request as draft January 29, 2025 16:58
obycode
obycode previously approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

obycode
obycode reviewed Jan 30, 2025
View reviewed changes
hstove
hstove previously approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Unfortunately, there are small conflicts so we'll have to re-approve.

jcnelson
jcnelson previously approved these changes Feb 4, 2025
View reviewed changes
@jferrant jferrant dismissed stale reviews from jcnelson, hstove, and obycode via 32a47ce February 5, 2025 02:42
@hstove hstove linked an issue Feb 5, 2025 that may be closed by this pull request
[Signer] Miner activity should only count specific bad block proposals #5749
Closed
hstove
hstove previously approved these changes Feb 5, 2025
View reviewed changes
obycode
obycode previously approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rdeioris
rdeioris previously approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@rdeioris rdeioris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jferrant jferrant dismissed stale reviews from rdeioris, obycode, and hstove via a4e152a February 5, 2025 18:04
@jferrant jferrant enabled auto-merge February 5, 2025 18:08
@jferrant jferrant added this pull request to the merge queue Feb 5, 2025
Merged via the queue into develop with commit 308861e Feb 5, 2025
12 checks passed
@jferrant jferrant deleted the feat/last-active-timestamp branch February 5, 2025 19:07
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Feb 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hstove hstove hstove approved these changes

@obycode obycode obycode approved these changes

@kantai kantai Awaiting requested review from kantai

@jcnelson jcnelson Awaiting requested review from jcnelson

@rdeioris rdeioris Awaiting requested review from rdeioris

Assignees

@jferrant jferrant

Labels
locked
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
3.1.0.0.6
Development

Successfully merging this pull request may close these issues.

[Signer] Miner activity should only count specific bad block proposals
7 participants
@jferrant @blockstack-devops @jcnelson @hstove @obycode @rdeioris @aldur