Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miner_forking test #5707

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Fix miner_forking test #5707

merged 2 commits into from
Jan 17, 2025

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented Jan 15, 2025

Before checking for the tip to be updated, make sure that both nodes have received the newest burn block

@jferrant jferrant changed the title Fix miner_forking test: wait for sortition tip to update before asserting which miner won its sortition Fix miner_forking test Jan 15, 2025
@jferrant jferrant force-pushed the fix/miner-forking branch 3 times, most recently from fc683ce to 7e51e19 Compare January 15, 2025 21:19
@jferrant jferrant marked this pull request as ready for review January 15, 2025 23:28
@jferrant jferrant requested a review from a team as a code owner January 15, 2025 23:28
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

Copy link
Contributor

@rdeioris rdeioris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jferrant jferrant added this pull request to the merge queue Jan 17, 2025
Merged via the queue into develop with commit 403aefc Jan 17, 2025
175 of 184 checks passed
@jferrant jferrant deleted the fix/miner-forking branch January 17, 2025 17:56
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Jan 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants