Fix get_latest_block_proposal function to return an err if no block proposals in list #5689
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s empty Signed-off-by: Jacinta Ferrant <[email protected]>
obycode
reviewed
Jan 14, 2025
obycode
approved these changes
Jan 14, 2025
hstove
approved these changes
Jan 15, 2025
jcnelson
approved these changes
Jan 15, 2025
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
signer_chainstate was failing about 50% of the time on develop due to a timing issue where a block proposal had not arrived when the blind signer attempted to sign a block proposal (would just unwrap the popped value in the list). This probably manifested in any nakamoto_integration test, but I just saw it in signer_chainstate. Making it return an err fixes the issue as it is already handled in a loop on err.