Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add consensus hash to signer's new proposal log #5685

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Jan 13, 2025

This will allow us to easily identify which signer the proposal came from when reviewing logs.

This will allow us to easily identify which signer the proposal came
from when reviewing logs.
@obycode obycode requested a review from a team as a code owner January 13, 2025 17:12
@obycode obycode requested review from jferrant and a team January 13, 2025 17:12
@obycode obycode requested a review from hstove January 14, 2025 17:22
@obycode obycode enabled auto-merge January 14, 2025 17:29
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This suggestion is too much to bolt on to this PR, but another nice thing would be to have a consistent label for signer_signature_hash in logs. Opened a "good first issue" ticket for that: #5692

@obycode obycode added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 14, 2025
@obycode obycode added this pull request to the merge queue Jan 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Jan 14, 2025
@obycode
Copy link
Contributor Author

obycode commented Jan 14, 2025

I'm not clear why the tests are not running when this is in the merge queue. Any thoughts?

@obycode obycode added this pull request to the merge queue Jan 15, 2025
Merged via the queue into develop with commit 6621956 Jan 15, 2025
170 of 172 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Jan 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants