Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Signer Alongside Node #5495

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

BowTiedDevOps
Copy link
Collaborator

The aim of this PR is to create a signer release every time there is a core release happening, with the tag set as <core_release>.0.

This PR also moves most of the release workflow out of stacks-core and into actions repository such that on subsequent changes to the release process, we can easier adjust the workflows without the need of as many stacks-core pull requests.

I've also implemented latest docker image tags on non-RC releases and removed the signer- word from the signer version tag as it was redundant.

Note: The Actions PR will have to be merged before this can be merged, as it references composite actions that are not existent in the current flow but in the one proposed by that PR.

Example workflows (tests commented out for quicker workflow runs, but they are unaffected by these changes):

Useful Links:

Binaries Version Check:

  • Node Release
    $ ./stacks-node version
    INFO [1732236056.645827] [testnet/stacks-node/src/main.rs:283] [main] stacks-node 4.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, 
    release build, linux [x86_64])
    stacks-node 4.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, release build, linux [x86_64])
    
    $ ./stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, release build, linux [x86_64])
  • Signer Release Built Alongside Node
    $ ./stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, release build, linux [x86_64])
  • Standalone Signer Release:
    $ ./stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.1 (release/signer-4.0.0.0.0.1:eb8aaf7, release build, linux [x86_64])
  • Standalone Signer Release (RC Build):
    $ ./stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.2-rc1 (release/signer-4.0.0.0.0.2-rc1:eb8aaf7, release build, linux [x86_64])

Docker Images Version Check:

  • Node
    $ docker run bowtieddevops/stacks-core:4.0.0.0.0 stacks-node version
    stacks-node 4.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, release build, linux [x86_64])
    INFO [1732236172.154954] [testnet/stacks-node/src/main.rs:283] [main] stacks-node 4.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, 
    release build, linux [x86_64])
    
    $ docker run bowtieddevops/stacks-core:latest stacks-node version
    INFO [1732236216.647136] [testnet/stacks-node/src/main.rs:283] [main] stacks-node 4.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, 
    release build, linux [x86_64])
    stacks-node 4.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, release build, linux [x86_64])
  • Signer
    $ docker run bowtieddevops/stacks-signer:4.0.0.0.0.0 stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.0 (release/4.0.0.0.0:eb8aaf7, release build, linux [x86_64])
    
    $ docker run bowtieddevops/stacks-signer:4.0.0.0.0.1 stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.1 (release/signer-4.0.0.0.0.1:eb8aaf7, release build, linux [x86_64])
    
    $ docker run bowtieddevops/stacks-signer:4.0.0.0.0.2-rc1 stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.2-rc1 (release/signer-4.0.0.0.0.2-rc1:eb8aaf7, release build, linux [x86_64])
    
    $ docker run bowtieddevops/stacks-signer:latest stacks-signer --version
    stacks-signer stacks-signer 4.0.0.0.0.1 (release/signer-4.0.0.0.0.1:eb8aaf7, release build, linux [x86_64])

- move most of the release workflow out of `stacks-core` and into `actions`
@BowTiedDevOps BowTiedDevOps added enhancement Iterations on existing features or infrastructure. CI labels Nov 22, 2024
@BowTiedDevOps BowTiedDevOps self-assigned this Nov 22, 2024
@BowTiedDevOps BowTiedDevOps requested a review from a team as a code owner November 22, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI enhancement Iterations on existing features or infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant