Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split get-(burn)-block-info linker function #5481

Open
wants to merge 3 commits into
base: feat/clarity-wasm-develop
Choose a base branch
from

Conversation

BowTiedWoo
Copy link

This PR splits get-block-info and get-burn-block-info so every property has its own linked function in order to avoid pushing every property of the get-block-info and get-burn-block-info functions to the stack once they are called.

e.g. when the function get-block-info is compiled, the compiler generates the code for all the available properties.
With this change, when get-block-info is compiled it will generate only the property that is called.

Related issue: stacks-network/clarity-wasm#430

@BowTiedWoo BowTiedWoo requested a review from a team as a code owner November 19, 2024 13:58
@BowTiedWoo BowTiedWoo force-pushed the feat/clarity-wasm-split-get-(burn)-block-info-linker-fn branch from fcf3389 to 40059a5 Compare November 21, 2024 13:31
@BowTiedWoo BowTiedWoo requested review from a team as code owners November 21, 2024 13:35
@BowTiedWoo BowTiedWoo force-pushed the feat/clarity-wasm-split-get-(burn)-block-info-linker-fn branch 2 times, most recently from 1d3fd28 to 371153b Compare November 26, 2024 15:40
Copy link
Contributor

@Acaccia Acaccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants