feat: event emitter will now emit new_txid in-case a tx replaces another #5381
+61
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e_release_to_master merge release/3.0.0.0.0 to master
|
|
jferrant
previously approved these changes
Oct 24, 2024
|
I could be wrong, but I think this may need to be opened against develop, not master. |
|
@jferrant yes didn't know it existed. |
|
@usagi32 you'll have to fix some of the formatting errors before CI runs tests - you can see these by running |
jcnelson
previously approved these changes
Nov 21, 2024
hstove
previously approved these changes
Nov 21, 2024
|
Ah, unfortunately there's a new compilation error, assuming from after merging in develop. |
|
Fixed build errors and merged latest |
hstove
approved these changes
Nov 25, 2024
obycode
requested changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extra information is required by an issue in the blockchain-api here and here.
Event emitter will now give to the api node which transaction replaced another.