Feat/shadow block tooling #5362
Merged
+714
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kantai
reviewed
Oct 23, 2024
…so we can use them for testing
Co-authored-by: Brice Dobry <[email protected]>
…-network/stacks-blockchain into feat/shadow-block-tooling
…hadow tenure entry
jferrant
reviewed
Nov 8, 2024
| } | ||
| }; | ||
|
|
||
| let chain_state_path = format!("{}/{}/chainstate/", chainstate_dir, dirname); |
There was a problem hiding this comment.
Not important, but would be nice if chain_state_path and sort_db_path used in place formatting :) (similarly throughout, but just a nit and not required of course)
jferrant
reviewed
Nov 8, 2024
| let (miner_pk_hash160, stacks_parent_ch, committed_block_hash, last_sortition_ch) = | ||
| if !sortition_sn.sortition { | ||
| if !sortition_sn.sortition && !is_shadow { |
There was a problem hiding this comment.
This is a bit of a personal preference, but I find this code block easier to understand if you do the following:
if !sortition_sn.sortition {
if !is_shadow {
let handle = sortdb.index_handle(&sortition_sn.sortition_id);
let last_sortition =
handle.get_last_snapshot_with_sortition(sortition_sn.block_height)?;
(None, None, None, Some(last_sortition.consensus_hash))
} else {
// this is a shadow tenure.
let parent_tenure_ch = chainstate
.index_conn()
.get_parent_tenure_consensus_hash(tip, &sortition_sn.consensus_hash)?
.ok_or_else(|| DBError::NotFoundError)?;
let parent_tenure_start_header =
NakamotoChainState::get_nakamoto_tenure_start_block_header(
&mut chainstate.index_conn(),
tip,
&parent_tenure_ch,
)?
.ok_or_else(|| DBError::NotFoundError)?;
(
Some(Hash160([0x00; 20])),
Some(parent_tenure_ch.clone()),
Some(BlockHeaderHash(
parent_tenure_start_header.index_block_hash().0,
)),
Some(parent_tenure_ch),
)
}
} else {
let block_commit = SortitionDB::get_block_commit(sortdb.conn(), &sortition_sn.winning_block_txid,
...
jferrant
approved these changes
Nov 11, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tooling to
stacks-inspectto generate and insert shadow blocks into a production chainstate.It'll probably get more commits as we test it out, but it's opened here for review so we can start making images off of it and testing it out on Nakamoto testnet.