Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Conditional logging for 'Proceeding to mine blocks' message #5338 #5348

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

Parikalp-Bhardwaj
Copy link
Contributor

Summary

  • This PR fixes an issue where the node logs Proceeding to mine blocks even when running as a follower node. The log message is now conditional on the node being a miner.

Changes

  • Added a conditional check around the log message to ensure it only appears when the node is configured as a miner.

Related Issues

@Parikalp-Bhardwaj Parikalp-Bhardwaj requested a review from a team as a code owner October 21, 2024 20:18
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@obycode obycode requested a review from a team October 23, 2024 02:50
@obycode obycode added this pull request to the merge queue Oct 23, 2024
Merged via the queue into stacks-network:develop with commit f299dd1 Oct 23, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants