Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve signer logging #5025

Merged
merged 2 commits into from
Aug 1, 2024
Merged

chore: improve signer logging #5025

merged 2 commits into from
Aug 1, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Jul 31, 2024

No description provided.

@obycode obycode requested review from a team as code owners July 31, 2024 04:44
@obycode obycode requested review from BowTiedDevOps and ASuciuX and removed request for BowTiedDevOps July 31, 2024 04:44
@jferrant
Copy link
Collaborator

Confused as to why empty sortition is failing. This test passes locally for me in develop and in this PR.

@obycode
Copy link
Contributor Author

obycode commented Jul 31, 2024

Confused as to why empty sortition is failing. This test passes locally for me in develop and in this PR.

Yeah that is strange. Clearly not related to these changes.

@wileyj
Copy link
Collaborator

wileyj commented Jul 31, 2024 •
edited
Loading

Confused as to why empty sortition is failing. This test passes locally for me in develop and in this PR.

Yeah that is strange. Clearly not related to these changes.

I've noticed the same - confirmed it passes locally, so i wouldn't worry about it for now since other things are higher priority.
i'll create an issue to track it

#5032

ASuciuX
ASuciuX approved these changes Aug 1, 2024
View reviewed changes
Copy link
Contributor

@ASuciuX ASuciuX left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i wouldn't worry about the unviable mutant https://github.com/stacks-network/stacks-core/actions/runs/10185995218?pr=5025.

@obycode obycode added this pull request to the merge queue Aug 1, 2024
Merged via the queue into develop with commit 5a3825d Aug 1, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jferrant jferrant jferrant approved these changes

@ASuciuX ASuciuX ASuciuX approved these changes

Assignees
No one assigned
Labels
locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@obycode @jferrant @wileyj @blockstack-devops @ASuciuX