Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Eliminate block between 2.5 and 3.0 #5009

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented Jul 25, 2024

Description

Modify integration tests so that they don't produce an extra block in between Epoch 2.5 and 3.0. Add a check to make sure that no burnchain blocks are missing from Stacks blockchain

Applicable issues

Additional info (benefits, drawbacks, caveats)

Should I add the contains_burn_block_range() check to all integration tests?

@saralab saralab requested review from kantai and obycode July 25, 2024 13:56
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I don't think it's necessary to add the contains_burn_block_range check in all tests. As long as it's in one, it should do the job.

@jbencin jbencin marked this pull request as ready for review July 26, 2024 00:46
@jbencin jbencin requested a review from a team as a code owner July 26, 2024 00:46
@jbencin jbencin force-pushed the test/eliminate-block-between-2.5-and-3.0 branch from e09903e to b78afdc Compare July 26, 2024 00:46
@jbencin jbencin enabled auto-merge July 26, 2024 01:00
@jbencin jbencin added this pull request to the merge queue Jul 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 26, 2024
@jbencin jbencin added this pull request to the merge queue Jul 26, 2024
Merged via the queue into stacks-network:develop with commit 899ca58 Jul 26, 2024
1 check passed
@jbencin jbencin deleted the test/eliminate-block-between-2.5-and-3.0 branch July 26, 2024 20:29
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants