Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: signer slots count in staging #4891

Merged
merged 2 commits into from
Jun 18, 2024
Merged

Conversation

kantai
Copy link
Member

@kantai kantai commented Jun 18, 2024

This fixes in the release branch the slot count for the .signers contract. It also adds a unit test that asserts the value is unchanging.

Will also open a PR against develop for this.

@kantai kantai requested a review from a team as a code owner June 18, 2024 14:53
wileyj
wileyj previously approved these changes Jun 18, 2024
Copy link
Collaborator

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@kantai kantai requested a review from jcnelson June 18, 2024 15:15
jcnelson
jcnelson previously approved these changes Jun 18, 2024
@kantai kantai force-pushed the fix/signer-slots-count branch from f94aa7a to 6e64d0d Compare June 18, 2024 15:29
@kantai kantai dismissed stale reviews from wileyj and jcnelson via e4770f6 June 18, 2024 16:01
@kantai kantai requested a review from a team as a code owner June 18, 2024 16:01
@kantai kantai merged commit 5309358 into release/2.5.0.0.4 Jun 18, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants