-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Timing of Nakamoto miner block production #4823
test: Timing of Nakamoto miner block production #4823
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4823 +/- ##
============================================
+ Coverage 21.46% 80.81% +59.35%
============================================
Files 476 481 +5
Lines 343843 345369 +1526
Branches 0 323 +323
============================================
+ Hits 73796 279121 +205325
+ Misses 270047 66240 -203807
- Partials 0 8 +8
... and 427 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add this test to .github/workflows/bitcoin-tests.yml
?
bce277f
to
4804c17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
51f51a5
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This PR changes the default value for
nakamoto_attempt_time_ms
to 20 seconds and adds an integration test,test_nakamoto_attempt_time
, to check that this value works as expected. Specifically, it checks the following:nakamoto_attempt_time_ms
nakamoto_attempt_time_ms
to include them all in a single block, blocks will still be produced at the rate ofnakamoto_attempt_time_ms
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml