-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Rename .cargo/config
-> .cargo/config.toml
to fix warning
#4799
fix: Rename .cargo/config
-> .cargo/config.toml
to fix warning
#4799
Conversation
Looks like we need a corresponding change in https://github.com/stacks-network/actions/blob/c822d00b31e61951d72a4c051e30887afd930036/rustfmt/action.yml#L37C57-L37C63 Please also update the mentions of this file in docs/profiling.md and README.md. |
Opened PR in actions repo here: stacks-network/actions#42 |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. We'll need @jw to help with the timing of the update to the action.
the action PR has been merged. i'll tigger a re-run here to see if checks pass now |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4799 +/- ##
============================================
+ Coverage 22.80% 83.56% +60.76%
============================================
Files 470 477 +7
Lines 342865 344315 +1450
Branches 0 323 +323
============================================
+ Hits 78188 287731 +209543
+ Misses 264677 56576 -208101
- Partials 0 8 +8 see 437 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
The latest release of Rust (1.78) gives a warning if you have a file named
.cargo/config
. I renamed it to.cargo/config.toml
, as suggested by Cargo, to silence the warning.