Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename .cargo/config -> .cargo/config.toml to fix warning #4799

Merged
merged 3 commits into from
May 23, 2024

Conversation

jbencin
Copy link
Contributor

@jbencin jbencin commented May 16, 2024

Description

The latest release of Rust (1.78) gives a warning if you have a file named .cargo/config. I renamed it to .cargo/config.toml, as suggested by Cargo, to silence the warning.

@jbencin jbencin requested review from a team as code owners May 16, 2024 13:30
ASuciuX
ASuciuX previously approved these changes May 16, 2024
@obycode
Copy link
Contributor

obycode commented May 16, 2024

Looks like we need a corresponding change in https://github.com/stacks-network/actions/blob/c822d00b31e61951d72a4c051e30887afd930036/rustfmt/action.yml#L37C57-L37C63

Please also update the mentions of this file in docs/profiling.md and README.md.

@jbencin
Copy link
Contributor Author

jbencin commented May 16, 2024

Opened PR in actions repo here: stacks-network/actions#42

@jbencin
Copy link
Contributor Author

jbencin commented May 17, 2024

Please also update the mentions of this file in docs/profiling.md and README.md

Done

Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. We'll need @jw to help with the timing of the update to the action.

@wileyj
Copy link
Contributor

wileyj commented May 20, 2024

This looks good to me. We'll need @jw to help with the timing of the update to the action.

the action PR has been merged. i'll tigger a re-run here to see if checks pass now

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (9addd7e) to head (2aa0824).
Report is 14 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4799       +/-   ##
============================================
+ Coverage    22.80%   83.56%   +60.76%     
============================================
  Files          470      477        +7     
  Lines       342865   344315     +1450     
  Branches         0      323      +323     
============================================
+ Hits         78188   287731   +209543     
+ Misses      264677    56576   -208101     
- Partials         0        8        +8     

see 437 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf01028...2aa0824. Read the comment docs.

Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shipit

@wileyj wileyj added this pull request to the merge queue May 23, 2024
Merged via the queue into stacks-network:develop with commit c7c0ed7 May 23, 2024
2 checks passed
@jbencin jbencin deleted the fix/cargo-config-warning branch May 24, 2024 18:33
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants