-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signers-Voting Chore(s): Round Up & Round-Data Getter #4496
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #4496 +/- ##
==========================================
- Coverage 83.35% 83.12% -0.23%
==========================================
Files 453 453
Lines 328223 328342 +119
Branches 323 323
==========================================
- Hits 273574 272942 -632
- Misses 54641 55392 +751
Partials 8 8
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarity code looks good and I've manually tested the round up mechanism, and it works as expected
d3b8e38
to
4ef96a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks @setzeus
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question, but that's just from not being sure how state is setup in this test. LGTM!
4ef96a4
to
c42778f
Compare
f98c058
to
6e4113c
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
This is a small PR that addresses two small issues found in the .Signers-Voting.clar Clarity contract. In draft as is it's still missing relevant tests.
Applicable issues
#4457
#4487
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yaml
andrpc-endpoints.md
for v2 endpoints,event-dispatcher.md
for new events)clarity-benchmarking
repobitcoin-tests.yml