Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signers-Voting Chore(s): Round Up & Round-Data Getter #4496

Merged
merged 14 commits into from
Mar 16, 2024

Conversation

setzeus
Copy link
Collaborator

@setzeus setzeus commented Mar 6, 2024

Description

This is a small PR that addresses two small issues found in the .Signers-Voting.clar Clarity contract. In draft as is it's still missing relevant tests.

Applicable issues

#4457
#4487

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 90.08264% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 83.12%. Comparing base (6278946) to head (6e4113c).

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #4496      +/-   ##
==========================================
- Coverage   83.35%   83.12%   -0.23%     
==========================================
  Files         453      453              
  Lines      328223   328342     +119     
  Branches      323      323              
==========================================
- Hits       273574   272942     -632     
- Misses      54641    55392     +751     
  Partials        8        8              
Files Coverage Δ
...src/chainstate/stacks/boot/signers_voting_tests.rs 96.19% <100.00%> (+0.22%) ⬆️
...lib/src/chainstate/stacks/boot/signers-voting.clar 8.33% <0.00%> (-1.35%) ⬇️

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6278946...6e4113c. Read the comment docs.

Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarity code looks good and I've manually tested the round up mechanism, and it works as expected

@setzeus setzeus marked this pull request as ready for review March 7, 2024 22:36
obycode
obycode previously approved these changes Mar 8, 2024
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks @setzeus

@hstove hstove self-requested a review March 11, 2024 15:35
hstove
hstove previously approved these changes Mar 11, 2024
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a question, but that's just from not being sure how state is setup in this test. LGTM!

@obycode obycode enabled auto-merge March 14, 2024 01:48
@obycode obycode disabled auto-merge March 14, 2024 01:48
@setzeus setzeus dismissed stale reviews from obycode and hstove via f98c058 March 15, 2024 21:19
@obycode obycode enabled auto-merge March 16, 2024 01:55
@obycode obycode added this pull request to the merge queue Mar 16, 2024
Merged via the queue into next with commit d3f1a31 Mar 16, 2024
2 checks passed
@obycode obycode deleted the chore/weight-round-up branch March 16, 2024 02:25
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants