Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miner should pause after a block rejection #5405

Closed
obycode opened this issue Oct 30, 2024 · 1 comment
Closed

Miner should pause after a block rejection #5405

obycode opened this issue Oct 30, 2024 · 1 comment
Assignees
@obycode
Labels
locked performance-optimizations
Milestone
Nakamoto-3.0.x

Comments

@obycode
Copy link
Contributor

obycode commented Oct 30, 2024

When a miner gets a block rejection, it should pause some amount of time before submitting a new proposal. Without this, it can get into a cycle where it is proposing blocks too quickly, which can overwhelm the signers. Suggestion from @kantai is to wait 5s on the first rejection, then 10s after subsequent rejections.
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Oct 30, 2024
@obycode obycode self-assigned this Oct 30, 2024
obycode added a commit that referenced this issue Oct 30, 2024
@obycode
feat: add pause after block rejections
d734345 
Fixes: #5405
@obycode obycode mentioned this issue Oct 30, 2024
Merged
@saralab saralab added this to the Nakamoto-3.0.x milestone Oct 30, 2024
@saralab saralab moved this from Status: 🆕 New to Status: 💻 In Progress in Stacks Core Eng Oct 30, 2024
@saralab saralab moved this from Status: 💻 In Progress to Status: ✅ Done in Stacks Core Eng Oct 30, 2024
@hstove hstove closed this as completed Oct 31, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 8, 2024
rdeioris pushed a commit that referenced this issue Nov 10, 2024
@obycode @rdeioris
feat: add pause after block rejections
90c0790 
Fixes: #5405
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@obycode obycode

Labels
locked performance-optimizations
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
Nakamoto-3.0.x
Development

No branches or pull requests
4 participants
@saralab @hstove @obycode @blockstack-devops