Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit the clarity_vm code paths once the chainstate is fully MARF'ed #4900

Closed
obycode opened this issue Jun 21, 2024 · 2 comments
Closed

Revisit the clarity_vm code paths once the chainstate is fully MARF'ed #4900

obycode opened this issue Jun 21, 2024 · 2 comments
Assignees
@jcnelson
Labels
3.0-must 3.0 locked
Milestone
Nakamoto Mileston...

Comments

@obycode
Copy link
Contributor

obycode commented Jun 21, 2024 

          Approving for now, but please open an issue to revisit the `clarity_vm` code paths once the chainstate is fully MARF'ed.  Thanks!

Originally posted by @jcnelson in #4846 (review)
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Jun 21, 2024
@obycode obycode self-assigned this Jun 21, 2024
@obycode
Copy link
Contributor Author

obycode commented Jun 21, 2024

For example, get_first_block_in_tenure can be simplified once that work is complete:

Broadly speaking, this is just a placeholder. When the chainstate is fully MARF'ed, the code here will instead simply query the headers MARF for the given Stacks block's first-tenure block (literally 3 lines of code).

#4846 (comment)

@obycode obycode removed their assignment Jun 21, 2024
@obycode obycode mentioned this issue Jun 21, 2024
Merged
5 tasks
@saralab saralab added the 3.0 label Jun 25, 2024
@saralab saralab assigned jcnelson and unassigned obycode Jun 25, 2024
@saralab saralab moved this from Status: 🆕 New to Status: 💻 In Progress in Stacks Core Eng Jun 25, 2024
jcnelson added a commit that referenced this issue Jun 29, 2024
@jcnelson
chore: close #4900 by relying on the MARF for querying the tenure-sta…
a3ce626 
…rt block in the clarity VM
@jcnelson jcnelson mentioned this issue Jun 29, 2024
Merged
@saralab saralab moved this from Status: 💻 In Progress to Status: In Review in Stacks Core Eng Jul 1, 2024
@saralab saralab moved this from Status: In Review to Status: ✅ Done in Stacks Core Eng Jul 11, 2024
@saralab saralab closed this as completed Jul 11, 2024
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jcnelson jcnelson

Labels
3.0-must 3.0 locked
Projects
Stacks Core Eng
Archived in project
Milestone
Nakamoto Milestone 0.4 [3.0 Activation]
Development

No branches or pull requests
4 participants
@saralab @jcnelson @obycode @blockstack-devops