Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telemetry): zero value for cloud source telemetry #13957

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

stehessel
Copy link
Collaborator

@stehessel stehessel commented Jan 24, 2025

Description

Make sure to count non-existing cloud source types as zero in telemetry. Otherwise we'll get undefined values, which does not look as nice in the telemetry charts.

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

Copy link

openshift-ci bot commented Jan 24, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@stehessel stehessel marked this pull request as ready for review January 24, 2025 08:42
@stehessel stehessel requested a review from a team as a code owner January 24, 2025 08:42
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Jan 24, 2025

Images are ready for the commit at 801fa6d.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.7.x-512-g801fa6dc50.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.88%. Comparing base (36b7306) to head (801fa6d).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #13957      +/-   ##
==========================================
+ Coverage   48.84%   48.88%   +0.03%     
==========================================
  Files        2496     2496              
  Lines      180751   180746       -5     
==========================================
+ Hits        88289    88351      +62     
+ Misses      85446    85378      -68     
- Partials     7016     7017       +1     
Flag Coverage Δ
go-unit-tests 48.88% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stehessel stehessel force-pushed the fix/zero-value-cloudsource-telemetrygd branch from 25d6fa4 to 1959a36 Compare January 24, 2025 10:11
@stehessel stehessel force-pushed the fix/zero-value-cloudsource-telemetrygd branch 2 times, most recently from bd44996 to 7654173 Compare January 24, 2025 15:35
@stehessel stehessel force-pushed the fix/zero-value-cloudsource-telemetrygd branch from 7654173 to 801fa6d Compare January 25, 2025 15:55
@stehessel stehessel enabled auto-merge (squash) January 25, 2025 17:03
@stehessel stehessel merged commit b301bde into master Jan 25, 2025
80 of 84 checks passed
@stehessel stehessel deleted the fix/zero-value-cloudsource-telemetrygd branch January 25, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants