Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROX-22474: Do not build Konflux images with release GOTAG #11136

Merged
merged 1 commit into from
May 17, 2024

Conversation

tommartensen
Copy link
Contributor

Description

As a workaround, we need to build Konflux images without release GOTAG.
That is to use the SCANNER_VERSION and COLLECTOR_VERSION files to find the respective images.

Checklist

  • Investigated and inspected CI test results
  • Unit test and regression tests added
  • Evaluated and added CHANGELOG entry if required
  • Determined and documented upgrade steps
  • Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.

Testing Performed

Here I tell how I validated my change

TODO(replace-me)
Use this space to explain how you validated that your change functions exactly how you expect it.
Feel free to attach JSON snippets, curl commands, screenshots, etc. Apply a simple benchmark: would the information you
provided convince any reviewer or any external reader that you did enough to validate your change.

It is acceptable to assume trust and keep this section light, e.g. as a bullet-point list.

It is acceptable to skip testing in cases when CI is sufficient, or it's a markdown or code comment change only.
It is also acceptable to skip testing for changes that are too taxing to test before merging. In such case you are
responsible for the change after it gets merged which includes reverting, fixing, etc. Make sure you validate the change
ASAP after it gets merged or explain in PR when the validation will be performed.
Explain here why you skipped testing in case you did so.

Have you created automated tests for your change? Explain here which validation activities you did manually and why so.

Reminder for reviewers

In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

@tommartensen tommartensen requested a review from a team May 16, 2024 14:02
@tommartensen tommartensen requested a review from a team as a code owner May 16, 2024 14:02
@tommartensen tommartensen requested a review from a team May 16, 2024 14:02
@tommartensen
Copy link
Contributor Author

/retest

Copy link

openshift-ci bot commented May 16, 2024

@tommartensen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-scanner-v4-tests c663751 link false /test ocp-4-12-scanner-v4-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhacs-bot
Copy link
Contributor

Images are ready for the commit at c663751.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.4.x-704-gc6637518cd.

Copy link
Contributor

@msugakov msugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care about todos with a ticket reference!

@msugakov
Copy link
Contributor

msugakov commented May 16, 2024

Please double-check that scanner-v4 build is not broken by this, before merging. To me, it seems like it's not.
https://console.redhat.com/preview/application-pipeline/ns/rh-acs-tenant/pipelinerun/scanner-v4-on-pull-request-qhkmp

@tommartensen
Copy link
Contributor Author

Please double-check that scanner-v4 build is not broken by this, before merging. To me, it seems like it's not.

task show-summary has failed: TaskRun "scanner-v4-on-pull-request-qhkmp-show-summary" was cancelled. TaskRun cancelled as the PipelineRun it belongs to has timed out.

I agree, it looks like a generic timeout. Build finished successfully.

@tommartensen tommartensen merged commit c10dd47 into master May 17, 2024
72 of 79 checks passed
@tommartensen tommartensen deleted the tm/ROX-22474-konflux-images-no-release branch May 17, 2024 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants