Minor updates for #911 #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTann
commented
Sep 20, 2022
| @@ -63,6 +63,6 @@ func (m *FileExtractionMetrics) Emit() { | |||
| fileExtractionCountMetric.Observe(m.matchCount) | |||
| fileExtractionMatchCountMetric.Observe(m.fileCount) | |||
| fileExtractionInaccessibleCountMetric.Observe(m.inaccessibleCount) | |||
| *m = FileExtractionMetrics{} | |||
There was a problem hiding this comment.
this is the most important one, as without this change, there is potential for nil-dereference
daynewlee
approved these changes
Sep 20, 2022
|
Images are ready for the commit at e127923. To use the images, use the tag |
|
@RTann: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #927, make updates from comments left on #911 made after merge